Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 1157923004: Sync the SecurityPolicyViolationEvent interface with the spec (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
Mike West
CC:
blink-reviews, vivekg, mkwst+watchlist-csp_chromium.org, arv+blink, Inactive, vivekg_samsung
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Use [Measure] #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M Source/core/events/SecurityPolicyViolationEvent.idl View 1 1 chunk +6 lines, -4 lines 0 comments Download
M Source/core/events/SecurityPolicyViolationEventInit.idl View 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
philipj_slow
PTAL. What should we do about these discrepancies with the spec? Should I just throw ...
5 years, 6 months ago (2015-06-03 19:01:48 UTC) #2
Mike West
On 2015/06/03 at 19:01:48, philipj wrote: > PTAL. What should we do about these discrepancies ...
5 years, 6 months ago (2015-06-03 19:36:45 UTC) #3
philipj_slow
On 2015/06/03 19:36:45, Mike West wrote: > On 2015/06/03 at 19:01:48, philipj wrote: > > ...
5 years, 6 months ago (2015-06-03 21:20:07 UTC) #4
philipj_slow
I added [Measure], depending on the usage one of three things could make sense: Zero ...
5 years, 6 months ago (2015-06-04 13:17:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157923004/20001
5 years, 6 months ago (2015-06-04 13:18:19 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/65304)
5 years, 6 months ago (2015-06-04 16:00:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157923004/20001
5 years, 6 months ago (2015-06-04 16:55:49 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 18:15:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196517

Powered by Google App Engine
This is Rietveld 408576698