Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1157893002: Sync the BarProp interface with the spec (Closed)

Created:
5 years, 7 months ago by philipj_slow
Modified:
5 years, 7 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync the BarProp interface with the spec https://html.spec.whatwg.org/#barprop BUG=460722 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195871

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M Source/core/frame/BarProp.idl View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
philipj_slow
PTAL
5 years, 7 months ago (2015-05-25 14:49:33 UTC) #2
Jens Widell
LGTM
5 years, 7 months ago (2015-05-25 14:53:49 UTC) #3
Jens Widell
LGTM
5 years, 7 months ago (2015-05-25 14:53:49 UTC) #4
Jens Widell
On 2015/05/25 14:53:49, Jens Widell wrote: > LGTM Argh! Second time in a row I ...
5 years, 7 months ago (2015-05-25 14:55:54 UTC) #5
philipj_slow
On 2015/05/25 14:55:54, Jens Widell wrote: > On 2015/05/25 14:53:49, Jens Widell wrote: > > ...
5 years, 7 months ago (2015-05-25 18:08:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157893002/1
5 years, 7 months ago (2015-05-25 18:08:55 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-25 18:12:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195871

Powered by Google App Engine
This is Rietveld 408576698