Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Issue 1157863015: [turbofan] Split --turbo-exceptions into two flags. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Split --turbo-exceptions into two flags. This allows try-catch and try-finally constructs to be separately enabled and disabled. We plan to stage try-catch support soon. R=titzer@chromium.org Committed: https://crrev.com/b715329a1586733d892d147803b510fca63558b5 Cr-Commit-Position: refs/heads/master@{#28848}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/compiler/test-run-jsexceptions.cc View 14 chunks +12 lines, -14 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/compiler/try-deopt.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 6 months ago (2015-06-08 16:18:55 UTC) #1
titzer
lgtm
5 years, 6 months ago (2015-06-08 16:59:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157863015/1
5 years, 6 months ago (2015-06-08 17:10:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-08 18:22:01 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 18:22:08 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b715329a1586733d892d147803b510fca63558b5
Cr-Commit-Position: refs/heads/master@{#28848}

Powered by Google App Engine
This is Rietveld 408576698