ash/accelerators/accelerator_controller.cc - Issue 1157843009: Added wm::IsWindowUserPositionable(...) method in window_util.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/accelerators/accelerator_controller.cc

Issue 1157843009: Added wm::IsWindowUserPositionable(...) method in window_util.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added WindowState::IsUserPositionable() method. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/accelerators/accelerator_controller.cc

diff --git a/ash/accelerators/accelerator_controller.cc b/ash/accelerators/accelerator_controller.cc

index 5a6dba781a213a8716945bd23ea31ceb75b55dd3..54d517d5d2b6dd1414bbf185993bac73da42cf62 100644

--- a/ash/accelerators/accelerator_controller.cc

+++ b/ash/accelerators/accelerator_controller.cc

@@ -465,8 +465,7 @@ bool CanHandleWindowSnapOrDock() {

// Disable window snapping shortcut key for full screen window due to

// http://crbug.com/135487.

return (window_state &&

- (window_state->window()->type() == ui::wm::WINDOW_TYPE_NORMAL ||

- window_state->window()->type() == ui::wm::WINDOW_TYPE_PANEL) &&

+ wm::IsWindowUserPositionable(window_state->window()) &&

oshima 2015/06/04 19:49:11 window_state->IsUserPositionable() ?

bruthig 2015/06/04 19:56:23 Done.

!window_state->IsFullscreen());

}

« no previous file with comments | « no previous file | ash/root_window_controller.cc » ('j') | ash/wm/default_state.cc » ('J')