Issue 1157833002: Revert of Refactor the selection code in EventHandler

Issue 1157833002: Revert of Refactor the selection code in EventHandler (Closed)

Created:
5 years, 7 months ago by Will Harris

Modified:
5 years, 7 months ago

Reviewers:
yoichio, Miyoung Shin(g), tkent, Rick Byers, mfomitchev, yosin_UTC9

CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, eae+blinkwatch

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert of Refactor the selection code in EventHandler (patchset #6 id:120001 of https://codereview.chromium.org/1113323002/) Reason for revert: crbug.com/491501 text selection broken Original issue's description: > Refactor the selection code in EventHandler > > The code related to handling the selection > moves out of EventHandler to SelectionHandler. > This patch makes EventHandler simpler as well. > > BUG=483376 > R=yosin@chromium.org, rbyers@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195735 TBR=rbyers@chromium.org,yosin@chromium.org,mfomitchev@chromium.org,yoichio@chromium.org,tkent@chromium.org,myid.o.shin@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=483376, 491501 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195831

Created: 5 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+498 lines, -708 lines)			Patch
M	Source/core/core.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	Source/core/editing/SelectionController.h	View	1 chunk	+0 lines, -87 lines	0 comments	Download
D	Source/core/editing/SelectionController.cpp	View	1 chunk	+0 lines, -589 lines	0 comments	Download
M	Source/core/html/HTMLLabelElement.cpp	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	Source/core/page/EventHandler.h	View	6 chunks	+24 lines, -4 lines	0 comments	Download
M	Source/core/page/EventHandler.cpp	View	16 chunks	+473 lines, -24 lines	0 comments	Download

Total messages: 4 (0 generated)

Will Harris

Created Revert of Refactor the selection code in EventHandler

5 years, 7 months ago (2015-05-24 03:38:11 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157833002/1

5 years, 7 months ago (2015-05-24 03:38:16 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=195831

5 years, 7 months ago (2015-05-24 03:38:38 UTC) #3

Message was sent while issue was closed.

lgtm