Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 1157823003: Refactoring timing info for ServiceWorker controlled requests [2/3] (Closed)

Created:
5 years, 7 months ago by Kunihiko Sakamoto
Modified:
5 years, 7 months ago
Reviewers:
Tom Sepez, jam, mmenke, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactoring timing info for ServiceWorker controlled requests [2/3] Currently, three timings are collected for ServiceWorker controlled requests: serviceWorkerFetchStart, serviceWorkerFetchReady, and serviceWorkerFetchEnd. However serviceWorkerFetchReady and serviceWorkerFetchEnd are always the same value as sendStart and sendEnd, respectively. This three sided patch removes serviceWorkerFetchReady and serviceWorkerFetchEnd, and renames serviceWorkerFetchStart to workerStart, which is the name used in Navigation Timing and Resource Timing. [1/3] https://codereview.chromium.org/1159663002/ [2/3] THIS [3/3] https://codereview.chromium.org/1151263003/ BUG=465640 TEST=no functional change; all existing tests should pass. Committed: https://crrev.com/07794af3ab8783f8f0acf6ccb2b6f35aa9b8d48c Cr-Commit-Position: refs/heads/master@{#331732}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -67 lines) Patch
M content/browser/loader/resource_loader.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_context_request_handler.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_context_request_handler.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler.cc View 1 chunk +5 lines, -10 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.h View 2 chunks +2 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.cc View 5 chunks +5 lines, -11 lines 0 comments Download
M content/child/resource_dispatcher.cc View 1 chunk +1 line, -6 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M content/common/resource_messages.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/public/common/resource_response.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M content/public/common/resource_response_info.h View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Kunihiko Sakamoto
content/browser/loader: mmenke@ content/browser/service_worker: horo@ content/{child, common, public/common}: jam@ PTAL, thanks!
5 years, 7 months ago (2015-05-26 05:40:08 UTC) #2
horo
lgtm
5 years, 7 months ago (2015-05-26 06:14:59 UTC) #3
mmenke
loader/ LGTM
5 years, 7 months ago (2015-05-26 14:17:07 UTC) #4
jam
lgtm
5 years, 7 months ago (2015-05-26 15:51:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157823003/1
5 years, 7 months ago (2015-05-27 00:40:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/66074)
5 years, 7 months ago (2015-05-27 00:51:31 UTC) #9
Kunihiko Sakamoto
+tsepez@ for IPC
5 years, 7 months ago (2015-05-27 00:57:58 UTC) #11
Tom Sepez
Messages LGTM.
5 years, 7 months ago (2015-05-27 16:40:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157823003/1
5 years, 7 months ago (2015-05-28 00:55:10 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-28 02:55:14 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-28 02:56:17 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07794af3ab8783f8f0acf6ccb2b6f35aa9b8d48c
Cr-Commit-Position: refs/heads/master@{#331732}

Powered by Google App Engine
This is Rietveld 408576698