Chromium Code Reviews

Issue 11578051: Pass --tool=asan to run_tests.py on the ASan bot. (Closed)

Created:
8 years ago by eugenis
Modified:
7 years, 12 months ago
Reviewers:
bulach, Isaac (away), digit1
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Pass --tool=asan to run_tests.py on the ASan bot. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174574

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Stats (+4 lines, -2 lines)
M build/android/buildbot/bb_asan_tests.sh View 1 chunk +1 line, -0 lines 0 comments
M build/android/buildbot/buildbot_functions.sh View 2 chunks +3 lines, -2 lines 0 comments

Messages

Total messages: 7 (0 generated)
eugenis
8 years ago (2012-12-21 12:54:35 UTC) #1
Evgeniy Stepanov
I've got a feeling that I'm doing this the wrong way... Would it be better ...
8 years ago (2012-12-21 12:55:58 UTC) #2
Isaac (away)
Yeah don't add an environment variable. You can pass that as an argument to run_instrumentation_tests ...
8 years ago (2012-12-21 21:59:26 UTC) #3
Isaac (away)
Hi Eugenis, If you're not in a rush, I have a fix for this as ...
7 years, 12 months ago (2012-12-24 10:46:38 UTC) #4
Isaac (away)
And if you're in a rush, this patch LGTM since the file will be deleted ...
7 years, 12 months ago (2012-12-24 10:48:01 UTC) #5
Evgeniy Stepanov
On 2012/12/24 10:48:01, Isaac wrote: > And if you're in a rush, this patch LGTM ...
7 years, 12 months ago (2012-12-24 11:07:09 UTC) #6
Isaac (away)
7 years, 12 months ago (2012-12-24 11:11:18 UTC) #7
SGTM, land it.

Powered by Google App Engine