Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1643)

Unified Diff: chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc

Issue 11578044: Enable Search-key modifiers for extended key shortcuts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc
diff --git a/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc b/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc
index 52ac6f865f03605267a5f9722a35fed2ffd05e0e..44f95f0da590ad0eb051f4dfa720a988bfa0ce05 100644
--- a/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc
+++ b/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc
@@ -78,8 +78,6 @@ struct I18nContentToMessage {
{ "keyboardOverlayF12", IDS_KEYBOARD_OVERLAY_F12 },
{ "keyboardOverlayInsert", IDS_KEYBOARD_OVERLAY_INSERT },
{ "keyboardOverlayInstructions", IDS_KEYBOARD_OVERLAY_INSTRUCTIONS },
- { "keyboardOverlayInstructionsWithSearch",
- IDS_KEYBOARD_OVERLAY_INSTRUCTIONS_WITH_SEARCH },
{ "keyboardOverlayInstructionsHide", IDS_KEYBOARD_OVERLAY_INSTRUCTIONS_HIDE },
{ "keyboardOverlayActivateLastLauncherItem",
IDS_KEYBOARD_OVERLAY_ACTIVATE_LAST_LAUNCHER_ITEM },
@@ -240,7 +238,7 @@ std::string ModifierKeyToLabel(ModifierKey modifier) {
}
ChromeWebUIDataSource* CreateKeyboardOverlayUIHTMLSource(
- bool search_key_acts_as_function_key) {
+ bool keep_non_search_shortcuts) {
ChromeWebUIDataSource* source =
new ChromeWebUIDataSource(chrome::kChromeUIKeyboardOverlayHost);
@@ -250,8 +248,8 @@ ChromeWebUIDataSource* CreateKeyboardOverlayUIHTMLSource(
}
source->AddString("keyboardOverlayLearnMoreURL", UTF8ToUTF16(kLearnMoreURL));
- source->AddString("keyboardSearchKeyActsAsFunctionKey",
- search_key_acts_as_function_key ? "true" : "false");
+ source->AddString("keyboardKeepNonSearchKeyShortcuts",
+ keep_non_search_shortcuts ? "true" : "false");
source->set_json_path("strings.js");
source->set_use_json_js_format_v2();
source->add_resource_path("keyboard_overlay.js", IDR_KEYBOARD_OVERLAY_JS);
@@ -367,11 +365,11 @@ KeyboardOverlayUI::KeyboardOverlayUI(content::WebUI* web_ui)
KeyboardOverlayHandler* handler = new KeyboardOverlayHandler(profile);
web_ui->AddMessageHandler(handler);
- const bool search_key_acts_as_function_key =
- CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableChromebookFunctionKey);
+ const bool keep_non_search_shortcuts =
+ !CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kDisableNonSearchExtendedKeyShortcuts);
// Set up the chrome://keyboardoverlay/ source.
ChromeURLDataManager::AddDataSource(profile,
- CreateKeyboardOverlayUIHTMLSource(search_key_acts_as_function_key));
+ CreateKeyboardOverlayUIHTMLSource(keep_non_search_shortcuts));
}

Powered by Google App Engine
This is Rietveld 408576698