Desktop aura: Expand what the ViewsDelegate can do to new windows.

chrome/browser/ui/views/chrome_views_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/chrome_views_delegate.h"
 
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/event_disposition.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/prefs/scoped_user_pref_update.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/views/accessibility/accessibility_event_router_views.h"
 #include "chrome/common/pref_names.h"
 #include "ui/gfx/rect.h"
 #include "ui/gfx/screen.h"
 #include "ui/views/widget/native_widget.h"
 #include "ui/views/widget/widget.h"
 
 #if defined(OS_WIN)
 #include "chrome/browser/app_icon_win.h"
 #endif
 
 #if defined(USE_AURA) && !defined(OS_CHROMEOS)
+#include "chrome/browser/ui/host_desktop.h"
 #include "ui/views/widget/desktop_aura/desktop_native_widget_aura.h"
 #include "ui/views/widget/native_widget_aura.h"
 #endif
 
 #if defined(USE_ASH)
 #include "ash/shell.h"
 #include "chrome/browser/ui/ash/ash_init.h"
 #include "chrome/browser/ui/ash/ash_util.h"
 #endif
 
@@ skipping 128 matching lines @@
 int ChromeViewsDelegate::GetDispositionForEvent(int event_flags) {
   return chrome::DispositionFromEventFlags(event_flags);
 }
 
 content::WebContents* ChromeViewsDelegate::CreateWebContents(
     content::BrowserContext* browser_context,
     content::SiteInstance* site_instance) {
   return NULL;
 }
 
-views::NativeWidget* ChromeViewsDelegate::CreateNativeWidget(
-    views::Widget::InitParams::Type type,
-    views::internal::NativeWidgetDelegate* delegate,
-    gfx::NativeView parent,
-    gfx::NativeView context) {
+void ChromeViewsDelegate::OnWidgetInit(
+    views::Widget::InitParams* params,
+    views::internal::NativeWidgetDelegate* delegate) {
 #if defined(USE_AURA) && !defined(OS_CHROMEOS)
-  if (parent && type != views::Widget::InitParams::TYPE_MENU)
-    return new views::NativeWidgetAura(delegate);
-  // TODO(erg): Once we've threaded context to everywhere that needs it, we
-  // should remove this check here.
-  gfx::NativeView to_check = context ? context : parent;
-  if (chrome::GetHostDesktopTypeForNativeView(to_check) ==
-      chrome::HOST_DESKTOP_TYPE_NATIVE)
-    return new views::DesktopNativeWidgetAura(delegate);
+  // While the majority of the time, context wasn't plumbed through due to the
+  // existence of a global StackingClient, if this window is a toplevel, it's
+  // possible that there is no contextual state that we can use.
+  if (params->parent == NULL &&
+      params->context == NULL &&
+      params->top_level == true) {

[Ben Goodger (Google), 2012/12/13 23:47:41]

params->top_level

+    // We need to make a decision about where to place this window based on the
+    // desktop type.
+    switch (chrome::GetActiveDesktop()) {
+      case chrome::HOST_DESKTOP_TYPE_NATIVE: {

[Ben Goodger (Google), 2012/12/13 23:47:41]

you don't need the braces on each case since you're not declaring any locals.

+        // If we're native, we should give this window its own toplevel desktop
+        // widget.
+        params->native_widget = new views::DesktopNativeWidgetAura(delegate);
+        break;
+      }
+      case chrome::HOST_DESKTOP_TYPE_ASH: {
+#if defined(USE_ASH)

[robertshield, 2012/12/14 01:15:58]

How about moving the #if to completely surround the case statement, so that we
fall through to the NOTREACHED if we get HOST_DESKTOP_TYPE_ASH when USE_ASH is
not defined?

+        // If we're in ash, give this window the context of the main monitor.
+        params->context = ash::Shell::GetPrimaryRootWindow();
 #endif
-  return NULL;
+        break;
+      }
+      default: {
+        NOTREACHED();
+      }
+    }
+  } else {
+    if (params->parent && params->type != views::Widget::InitParams::TYPE_MENU)
+      params->native_widget = new views::NativeWidgetAura(delegate);
+
+    // TODO(erg): Once we've threaded context to everywhere that needs it, we
+    // should remove this check here.
+    gfx::NativeView to_check =
+        params->context ? params->context : params->parent;
+    if (chrome::GetHostDesktopTypeForNativeView(to_check) ==
+        chrome::HOST_DESKTOP_TYPE_NATIVE) {
+      params->native_widget = new views::DesktopNativeWidgetAura(delegate);
+    }
+  }
+#endif
 }