Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1157793003: [Telemetry] Remove BuildbotOutputFormatter (Closed)

Created:
5 years, 7 months ago by eakuefner
Modified:
5 years, 6 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Remove BuildbotOutputFormatter This CL removes BuildbotOutputFormatter and its dependencies from Telemetry. It modifies stringification of values slightly in order to accommodate non-Page stories. BUG=477056 Committed: https://crrev.com/4b5e1f04136ae059e83b45e18b5bb1c7cc76edc7 Cr-Commit-Position: refs/heads/master@{#331674}

Patch Set 1 #

Patch Set 2 : Finish CL #

Patch Set 3 : fix test :\ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -144 lines) Patch
M tools/telemetry/telemetry/internal/story_runner_unittest.py View 1 2 3 chunks +22 lines, -8 lines 0 comments Download
D tools/telemetry/telemetry/results/buildbot_output_formatter.py View 1 chunk +0 lines, -109 lines 0 comments Download
M tools/telemetry/telemetry/results/results_options.py View 5 chunks +5 lines, -19 lines 0 comments Download
M tools/telemetry/telemetry/value/failure.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/histogram.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/list_of_scalar_values.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/list_of_string_values.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/scalar.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/skip.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/string.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/trace.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
eakuefner
PTAL. FYI the reason for the value/ changes is as follows: 1. Values are compared ...
5 years, 7 months ago (2015-05-27 19:51:17 UTC) #2
nednguyen
lgtm
5 years, 7 months ago (2015-05-27 21:15:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157793003/40001
5 years, 6 months ago (2015-05-27 21:25:09 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-05-27 22:36:38 UTC) #6
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/4b5e1f04136ae059e83b45e18b5bb1c7cc76edc7 Cr-Commit-Position: refs/heads/master@{#331674}
5 years, 6 months ago (2015-05-27 22:38:32 UTC) #7
nednguyen
5 years, 6 months ago (2015-05-28 18:26:37 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1149373005/ by nednguyen@google.com.

The reason for reverting is: Break Downstream perf bots (BUG=493182).

Powered by Google App Engine
This is Rietveld 408576698