Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: components/infobars/core/confirm_infobar_delegate.h

Issue 1157733005: Make 'Google Smart Lock' a hyperlink in the password infobar on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/infobars/core/confirm_infobar_delegate.h
diff --git a/components/infobars/core/confirm_infobar_delegate.h b/components/infobars/core/confirm_infobar_delegate.h
index d36ea224a272009f16eb86c784a12442358af7fc..516873ac1f60f49b74193fa313dcd55d95e13a73 100644
--- a/components/infobars/core/confirm_infobar_delegate.h
+++ b/components/infobars/core/confirm_infobar_delegate.h
@@ -9,6 +9,7 @@
#include "base/strings/string16.h"
#include "components/infobars/core/infobar_delegate.h"
#include "components/infobars/core/infobar_manager.h"
+#include "ui/gfx/range/range.h"
namespace infobars {
class InfoBar;
@@ -33,6 +34,9 @@ class ConfirmInfoBarDelegate : public infobars::InfoBarDelegate {
// Returns the message string to be displayed for the InfoBar.
virtual base::string16 GetMessageText() const = 0;
+ // Defines the message substring to be displayed as a link.
+ virtual gfx::Range GetMessageLinkRange() const;
+
// Returns the buttons to be shown for this InfoBar.
virtual int GetButtons() const;
@@ -54,8 +58,8 @@ class ConfirmInfoBarDelegate : public infobars::InfoBarDelegate {
// in handling this call something triggers the infobar to begin closing.
virtual bool Cancel();
- // Returns the text of the link to be displayed, if any. Otherwise returns
- // and empty string.
+ // Returns the text of the link to be displayed after the message, if
+ // any. Otherwise returns and empty string.
gone 2015/06/05 17:44:25 nit: while you're here, and -> an
virtual base::string16 GetLinkText() const;
// Called when the Link (if any) is clicked. The |disposition| specifies how
« no previous file with comments | « chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm ('k') | components/infobars/core/confirm_infobar_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698