chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm - Issue 1157733005: Make 'Google Smart Lock' a hyperlink in the password infobar on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm

Issue 1157733005: Make 'Google Smart Lock' a hyperlink in the password infobar on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: vabr@ Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/save_password_infobar_delegate.cc ('k') | chrome/browser/ui/cocoa/infobars/save_password_infobar_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm

diff --git a/chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm b/chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm

index 78037d964bd3a7e72801d87a98912b96d22cd137..7a4823d84db9263b5fdc1807ce265ee18a4b5961 100644

--- a/chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm

+++ b/chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm

@@ -7,8 +7,10 @@

#include "base/logging.h"

#include "base/strings/sys_string_conversions.h"

#include "chrome/browser/infobars/infobar_service.h"

+#include "chrome/browser/ui/chrome_style.h"

#include "chrome/browser/ui/cocoa/infobars/infobar_cocoa.h"

#include "components/infobars/core/confirm_infobar_delegate.h"

+#include "skia/ext/skia_utils_mac.h"

#include "third_party/google_toolbox_for_mac/src/AppKit/GTMUILocalizerAndLayoutTweaker.h"

#import "ui/base/cocoa/cocoa_base_utils.h"

#import "ui/base/cocoa/controls/hyperlink_text_view.h"

@@ -121,9 +123,11 @@

HyperlinkTextView* view = (HyperlinkTextView*)label_.get();

[view setMessage:message withFont:font messageColor:[NSColor blackColor]];

if (linkLength != 0) {

+ NSColor* linkColor =

+ gfx::SkColorToCalibratedNSColor(chrome_style::GetLinkColor());

[view addLinkRange:NSMakeRange(linkOffset, linkLength)

withName:@""

- linkColor:[NSColor blueColor]];

+ linkColor:linkColor];

}