Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(17)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1157733004: [DevTools] Cleanup frontend-in-iframe support. (Closed)

Created:
4 years, 11 months ago by dgozman
Modified:
4 years, 11 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Cleanup frontend-in-iframe support. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196579

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -237 lines) Patch
M Source/devtools/BUILD.gn View 5 chunks +8 lines, -11 lines 0 comments Download
M Source/devtools/devtools.gyp View 6 chunks +5 lines, -8 lines 0 comments Download
M Source/devtools/devtools.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
D Source/devtools/front_end/devtools.html View 1 chunk +0 lines, -64 lines 0 comments Download
M Source/devtools/front_end/devtools.js View 11 chunks +26 lines, -151 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/main/Tests.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dgozman
Could you please take a look?
4 years, 11 months ago (2015-06-03 16:35:11 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157733004/1
4 years, 11 months ago (2015-06-03 16:35:21 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-06-03 19:12:39 UTC) #6
dgozman
Ping.
4 years, 11 months ago (2015-06-05 09:31:30 UTC) #7
pfeldman
lgtm
4 years, 11 months ago (2015-06-05 13:43:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157733004/1
4 years, 11 months ago (2015-06-05 13:48:42 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2015-06-05 15:04:20 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196579

Powered by Google App Engine
This is Rietveld 408576698