V8_Fatal now prints C++ stack trace in debug mode.

V8_Fatal now prints C++ stack trace in debug mode.

Currently only supported on Linux. When compiled with GCC, also demangles C++ identifier names.

Should make debugging those flaky crashes on buildbots easier... :)

R=mstarzinger@chromium.org,ulan@chromium.org
BUG=

Committed: http://code.google.com/p/v8/source/detail?r=13222

[ulan_google, 2012-12-14 12:40:31]

https://codereview.chromium.org/11577019/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/11577019/diff/1/build/common.gypi#newcode372
build/common.gypi:372: # Support for backtrace_symbols.
Maybe add a gyp flag to opt in for backtrace?

https://codereview.chromium.org/11577019/diff/1/src/platform-linux.cc
File src/platform-linux.cc (right):

https://codereview.chromium.org/11577019/diff/1/src/platform-linux.cc#newcode40
src/platform-linux.cc:40: #include <execinfo.h>
This should be guarded by GLIBC too, otherwise it doesn't compile on Android.

https://codereview.chromium.org/11577019/diff/1/src/platform-linux.cc#newcode424
src/platform-linux.cc:424: void* trace[100];
This should be guarded by GLIBC

[rossberg, 2012-12-14 13:53:20]

https://codereview.chromium.org/11577019/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/11577019/diff/1/build/common.gypi#newcode372
build/common.gypi:372: # Support for backtrace_symbols.
On 2012/12/14 12:40:31, ulan1 wrote:
> Maybe add a gyp flag to opt in for backtrace?

Done.

https://codereview.chromium.org/11577019/diff/1/src/platform-linux.cc
File src/platform-linux.cc (right):

https://codereview.chromium.org/11577019/diff/1/src/platform-linux.cc#newcode40
src/platform-linux.cc:40: #include <execinfo.h>
On 2012/12/14 12:40:31, ulan1 wrote:
> This should be guarded by GLIBC too, otherwise it doesn't compile on Android.

Done.

https://codereview.chromium.org/11577019/diff/1/src/platform-linux.cc#newcode424
src/platform-linux.cc:424: void* trace[100];
On 2012/12/14 12:40:31, ulan1 wrote:
> This should be guarded by GLIBC

Done.

[ulan_google, 2012-12-14 14:18:24]

LGTM

[ulan, 2012-12-14 14:18:57]

LGTM