chrome/browser/extensions/api/usb/usb_api.h - Issue 11577017: Update USB extension API with suggestions from review.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/usb/usb_api.h

Issue 11577017: Update USB extension API with suggestions from review. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/usb/usb_api.h

diff --git a/chrome/browser/extensions/api/usb/usb_api.h b/chrome/browser/extensions/api/usb/usb_api.h

index 7c79270ea6d3d99406371b90078a6dfcbd991514..4b27b28536b7c0a5d7d5d43e664feb3ad9b2c229 100644

--- a/chrome/browser/extensions/api/usb/usb_api.h

+++ b/chrome/browser/extensions/api/usb/usb_api.h

@@ -44,11 +44,11 @@ class UsbAsyncApiTransferFunction : public UsbAsyncApiFunction {

UsbAsyncApiTransferFunction();

virtual ~UsbAsyncApiTransferFunction();

- bool ConvertDirectionSafely(const std::string& input,

+ bool ConvertDirectionSafely(const extensions::api::usb::Direction& input,

UsbDevice::TransferDirection* output);

- bool ConvertRequestTypeSafely(const std::string& input,

+ bool ConvertRequestTypeSafely(const extensions::api::usb::RequestType& input,

UsbDevice::TransferRequestType* output);

- bool ConvertRecipientSafely(const std::string& input,

+ bool ConvertRecipientSafely(const extensions::api::usb::Recipient& input,

UsbDevice::TransferRecipient* output);

void OnCompleted(UsbTransferStatus status,