Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 1157663008: Add note pointing to internal histograms.xml location (Closed)

Created:
5 years, 6 months ago by James Cook
Modified:
5 years, 6 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add note pointing to internal histograms.xml location This helps Googlers find where the internal histograms are located, which makes it a little easier to migrate them out to the public file. BUG=none TEST=none Committed: https://crrev.com/42e72dcee17448fcb237b2afbc1862dfc392cf83 Cr-Commit-Position: refs/heads/master@{#333205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
James Cook
isherman, PTAL tools/histograms is its own git repo, so I'm still trying to figure out ...
5 years, 6 months ago (2015-06-05 18:09:32 UTC) #3
Ilya Sherman
LGTM On 2015/06/05 18:09:32, James Cook wrote: > isherman, PTAL > > tools/histograms is its ...
5 years, 6 months ago (2015-06-05 20:56:08 UTC) #4
James Cook
On 2015/06/05 20:56:08, Ilya Sherman wrote: > LGTM > > On 2015/06/05 18:09:32, James Cook ...
5 years, 6 months ago (2015-06-05 21:50:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157663008/1
5 years, 6 months ago (2015-06-05 21:51:47 UTC) #7
Ilya Sherman
On 2015/06/05 21:50:33, James Cook wrote: > On 2015/06/05 20:56:08, Ilya Sherman wrote: > > ...
5 years, 6 months ago (2015-06-05 21:55:25 UTC) #8
chromium-reviews
I pinged the bug and I'm talking to pgervais on infra. On Fri, Jun 5, ...
5 years, 6 months ago (2015-06-05 21:57:05 UTC) #9
Ilya Sherman
On 2015/06/05 21:57:05, James Cook wrote: > I pinged the bug and I'm talking to ...
5 years, 6 months ago (2015-06-05 22:01:06 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/30727)
5 years, 6 months ago (2015-06-06 00:05:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157663008/1
5 years, 6 months ago (2015-06-06 00:12:16 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-06 02:49:34 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-06 02:50:37 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42e72dcee17448fcb237b2afbc1862dfc392cf83
Cr-Commit-Position: refs/heads/master@{#333205}

Powered by Google App Engine
This is Rietveld 408576698