|
|
Created:
5 years, 6 months ago by James Cook Modified:
5 years, 6 months ago Reviewers:
Ilya Sherman CC:
chromium-reviews, asvitkine+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd note pointing to internal histograms.xml location
This helps Googlers find where the internal histograms are located, which
makes it a little easier to migrate them out to the public file.
BUG=none
TEST=none
Committed: https://crrev.com/42e72dcee17448fcb237b2afbc1862dfc392cf83
Cr-Commit-Position: refs/heads/master@{#333205}
Patch Set 1 #
Messages
Total messages: 16 (5 generated)
Patchset #2 (id:20001) has been deleted
jamescook@chromium.org changed reviewers: + isherman@chromium.org
isherman, PTAL tools/histograms is its own git repo, so I'm still trying to figure out how to add a README there. This should help for now.
LGTM On 2015/06/05 18:09:32, James Cook wrote: > isherman, PTAL > > tools/histograms is its own git repo, so I'm still trying to figure out how to > add a README there. This should help for now. I believe that tools/histograms is no longer used at all. Rather than adding a README file to it, perhaps we should delete the git repository? (Please do correct me if it seems to still be in use.)
On 2015/06/05 20:56:08, Ilya Sherman wrote: > LGTM > > On 2015/06/05 18:09:32, James Cook wrote: > > isherman, PTAL > > > > tools/histograms is its own git repo, so I'm still trying to figure out how to > > add a README there. This should help for now. > > I believe that tools/histograms is no longer used at all. Rather than adding a > README file to it, perhaps we should delete the git repository? (Please do > correct me if it seems to still be in use.) The last commit to tools/histograms says: " Re-create empty tools/histograms directory. This way, folks won't be broken by the removal. Plan is to delete this and the line from src-internal/DEPS that syncs it in a follow-up CL later. BUG=400825" So yeah, maybe deleting it is the right thing to do. I'm just worried about what got broken that necessitated adding it back. :-)
The CQ bit was checked by jamescook@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157663008/1
On 2015/06/05 21:50:33, James Cook wrote: > On 2015/06/05 20:56:08, Ilya Sherman wrote: > > LGTM > > > > On 2015/06/05 18:09:32, James Cook wrote: > > > isherman, PTAL > > > > > > tools/histograms is its own git repo, so I'm still trying to figure out how > to > > > add a README there. This should help for now. > > > > I believe that tools/histograms is no longer used at all. Rather than adding > a > > README file to it, perhaps we should delete the git repository? (Please do > > correct me if it seems to still be in use.) > > The last commit to tools/histograms says: > > " Re-create empty tools/histograms directory. > > This way, folks won't be broken by the removal. > > Plan is to delete this and the line from > src-internal/DEPS that syncs it in a follow-up > CL later. > > BUG=400825" > > So yeah, maybe deleting it is the right thing to do. I'm just worried about what > got broken that necessitated adding it back. :-) Heh, okay. Probably worth double-checking with whoever authored that commit. (Hopefully it wasn't me... because I don't remember it :P)
I pinged the bug and I'm talking to pgervais on infra. On Fri, Jun 5, 2015 at 2:55 PM, <isherman@chromium.org> wrote: > On 2015/06/05 21:50:33, James Cook wrote: > >> On 2015/06/05 20:56:08, Ilya Sherman wrote: >> > LGTM >> > >> > On 2015/06/05 18:09:32, James Cook wrote: >> > > isherman, PTAL >> > > >> > > tools/histograms is its own git repo, so I'm still trying to figure >> out >> > how > >> to >> > > add a README there. This should help for now. >> > >> > I believe that tools/histograms is no longer used at all. Rather than >> > adding > >> a >> > README file to it, perhaps we should delete the git repository? >> (Please do >> > correct me if it seems to still be in use.) >> > > The last commit to tools/histograms says: >> > > " Re-create empty tools/histograms directory. >> > > This way, folks won't be broken by the removal. >> > > Plan is to delete this and the line from >> src-internal/DEPS that syncs it in a follow-up >> CL later. >> > > BUG=400825" >> > > So yeah, maybe deleting it is the right thing to do. I'm just worried >> about >> > what > >> got broken that necessitated adding it back. :-) >> > > Heh, okay. Probably worth double-checking with whoever authored that > commit. > (Hopefully it wasn't me... because I don't remember it :P) > > https://codereview.chromium.org/1157663008/ > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On 2015/06/05 21:57:05, James Cook wrote: > I pinged the bug and I'm talking to pgervais on infra. Thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)
The CQ bit was checked by jamescook@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157663008/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/42e72dcee17448fcb237b2afbc1862dfc392cf83 Cr-Commit-Position: refs/heads/master@{#333205} |