src/disassembler.cc - Issue 1157663007: Greedy allocator: perf work

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/disassembler.cc

Issue 1157663007: Greedy allocator: perf work (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: addressed feedback Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/disassembler.cc

diff --git a/src/disassembler.cc b/src/disassembler.cc

index fbdda546465f190fcd3924ddcb4002739cdacc67..1c2e138b8cb91f7c5491b878d5a2fc5e4f223c8a 100644

--- a/src/disassembler.cc

+++ b/src/disassembler.cc

@@ -146,7 +146,7 @@ static int DecodeIt(Isolate* isolate, std::ostream* os,

}

// Instruction address and instruction offset.

- out.AddFormatted("%p %4d ", prev_pc, prev_pc - begin);

+ out.AddFormatted("%p %4X ", prev_pc, prev_pc - begin);

// Instruction.

out.AddFormatted("%s", decode_buffer.start());