Greedy allocator: perf work

src/disassembler.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/code-stubs.h"
 #include "src/codegen.h"
 #include "src/debug.h"
 #include "src/deoptimizer.h"
@@ skipping 128 matching lines @@
       }
     }
 
     // Comments.
     for (int i = 0; i < comments.length(); i++) {
       out.AddFormatted("                  %s", comments[i]);
       DumpBuffer(os, &out);
     }
 
     // Instruction address and instruction offset.
-    out.AddFormatted("%p  %4d  ", prev_pc, prev_pc - begin);
+    out.AddFormatted("%p  %4X  ", prev_pc, prev_pc - begin);

[Jarin, 2015/06/03 15:06:16]

Why did you change this? 

I am worried that tools relying on formatting here might be unhappy.

[Mircea Trofin, 2015/06/04 03:38:39]

"perf" (the tool) outputs offsets as hex, so this makes perf analysis much
easier. I share your worry though. I'll change to having a flag perhaps?

[Jarin, 2015/06/08 13:32:49]

Maybe use this only locally, or change the formatting in a separate change list.
It looks like your change does not format jump targets consistently, so we
should not really commit it as is.

 
     // Instruction.
     out.AddFormatted("%s", decode_buffer.start());
 
     // Print all the reloc info for this instruction which are not comments.
     for (int i = 0; i < pcs.length(); i++) {
       // Put together the reloc info
       RelocInfo relocinfo(pcs[i], rmodes[i], datas[i], converter.code());
 
       // Indent the printing of the reloc info.
@@ skipping 129 matching lines @@
 #else  // ENABLE_DISASSEMBLER
 
 int Disassembler::Decode(Isolate* isolate, std::ostream* os, byte* begin,
                          byte* end, Code* code) {
   return 0;
 }
 
 #endif  // ENABLE_DISASSEMBLER
 
 } }  // namespace v8::internal