Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1157623003: remove SK_LEGACY_STROKE_CURVES (Closed)

Created:
5 years, 7 months ago by caryclark
Modified:
5 years, 7 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove SK_LEGACY_STROKE_CURVES The change in Chrome has been landed so this guard is no longer needed. R=reed@google.com,fmalita@chromium.org BUG=102411 Committed: https://skia.googlesource.com/skia/+/a76b7a3b04bc0e937921a1eb38d713c619e60e4e

Patch Set 1 #

Patch Set 2 : work in progress #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -342 lines) Patch
M samplecode/SampleQuadStroker.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkStroke.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkStroke.cpp View 17 chunks +31 lines, -335 lines 0 comments Download
M src/core/SkStrokeRec.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157623003/1
5 years, 7 months ago (2015-05-22 13:09:01 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-22 13:21:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157623003/1
5 years, 7 months ago (2015-05-22 13:24:25 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 7 months ago (2015-05-22 13:24:26 UTC) #7
f(malita)
lgtm
5 years, 7 months ago (2015-05-22 13:26:21 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 13:26:56 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a76b7a3b04bc0e937921a1eb38d713c619e60e4e

Powered by Google App Engine
This is Rietveld 408576698