Issue 11576051: Revert 173259, broke win7 tests:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11576051: Revert 173259, broke win7 tests: (Closed)

Created:
8 years ago by Nico

Modified:
8 years ago

Reviewers:
zmo

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 173259, broke win7 tests: http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/13892/steps/content_unittests/logs/GpuSideBlacklisting GpuDataManagerImplTest.GpuSideBlacklisting: browser\gpu\gpu_data_manager_impl_unittest.cc(147): error: Value of: manager->GpuAccessAllowed() Actual: true Expected: false browser\gpu\gpu_data_manager_impl_unittest.cc(150): error: Value of: manager->GetBlacklistedFeatures() Actual: 4 Expected: GPU_FEATURE_TYPE_WEBGL | GPU_FEATURE_TYPE_ACCELERATED_2D_CANVAS Which is: 5 > Fix a bug in r173248 > > Otherwise it will fail GPU blacklisting. > > BUG=162928, 165374 > TEST=manual about:gpu on machines with blacklisted features > TBR=kbr > Review URL: https://codereview.chromium.org/11577033 TBR=zmo@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173266

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -15 lines)			Patch
	M	content/browser/gpu/gpu_data_manager_impl.cc	View		3 chunks	+9 lines, -15 lines	0 comments	Download

Total messages: 1 (0 generated)