chrome/browser/ui/webui/extensions/extension_icon_source.cc - Issue 11576030: Add size checks to extension icons to prevent out of memory conditions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_icon_source.cc

Issue 11576030: Add size checks to extension icons to prevent out of memory conditions (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/extensions/extension_icon_source.cc

===================================================================

--- chrome/browser/ui/webui/extensions/extension_icon_source.cc (revision 173105)

+++ chrome/browser/ui/webui/extensions/extension_icon_source.cc (working copy)

@@ -271,7 +271,7 @@

int size;

if (!base::StringToInt(size_param, &size))

return false;

- if (size <= 0)

+ if (size <= 0 || size > extension_misc::EXTENSION_ICON_GIGANTOR)

return false;

ExtensionIconSet::MatchType match_type;

« no previous file with comments | « no previous file | chrome/browser/ui/webui/favicon_source.cc » ('j') | no next file with comments »