Issue 11576028: Fiddle with includes so we don't break the build once we land https://bugs.webkit.org/show_bug.cgi?…

Issue 11576028: Fiddle with includes so we don't break the build once we land https://bugs.webkit.org/show_bug.cgi?… (Closed)

Created:
8 years ago by pilgrim_google

Modified:
8 years ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

More Reviews

Description

Fiddle with includes so we don't break the build once we land https://bugs.webkit.org/show_bug.cgi?id=104704 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173514

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/renderer/renderer_webkitplatformsupport_impl.h	View		1 chunk	+1 line, -0 lines	1 comment	Download
	M	content/worker/worker_webkitplatformsupport_impl.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

https://codereview.chromium.org/11576028/diff/1/content/renderer/renderer_webkitplatformsupport_impl.h File content/renderer/renderer_webkitplatformsupport_impl.h (right): https://codereview.chromium.org/11576028/diff/1/content/renderer/renderer_webkitplatformsupport_impl.h#newcode13 content/renderer/renderer_webkitplatformsupport_impl.h:13: #include "third_party/WebKit/Source/WebKit/chromium/public/WebSharedWorkerRepository.h" nit: sort "W" after "p" ... ignoring ...

8 years ago (2012-12-14 22:42:04 UTC) #1

darin (slow to review)

nevermind, i think i must be wrong, given that the linter is not complaining.

8 years ago (2012-12-14 22:46:01 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/11576028/1

8 years ago (2012-12-14 22:47:31 UTC) #4

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests

8 years ago (2012-12-15 03:24:15 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/11576028/1

8 years ago (2012-12-17 18:37:31 UTC) #6

Message was sent while issue was closed.

Change committed as 173514

Expand Messages | Collapse Messages