Implement radio button for Sky’s fn2

Implement radio button for Sky’s fn2

R=abarth@chromium.org, eseidel@chromium.org, abarth

Committed: https://chromium.googlesource.com/external/mojo/+/3188c0d06b6e00686dce9de238874d8cf5c9aa19

[eseidel, 2015-06-04 23:50:53]

eseidel@chromium.org changed reviewers:
+ eseidel@chromium.org, mpcomplete@chromium.org

[eseidel, 2015-06-04 23:50:54]

https://codereview.chromium.org/1157573012/diff/1/sky/engine/core/painting/Pa...
File sky/engine/core/painting/Paint.idl (right):

https://codereview.chromium.org/1157573012/diff/1/sky/engine/core/painting/Pa...
sky/engine/core/painting/Paint.idl:9: const unsigned short FILL_STYLE           
= 0;
If you're exposing these, can we use them in the callsites?

I think mpcomplete was having luck using enums too.

https://codereview.chromium.org/1157573012/diff/1/sky/sdk/lib/framework/compo...
File sky/sdk/lib/framework/components2/radio.dart (right):

https://codereview.chromium.org/1157573012/diff/1/sky/sdk/lib/framework/compo...
sky/sdk/lib/framework/components2/radio.dart:33: sky.Color color = highlight ?
new sky.Color(0xFF673AB7) : new sky.Color(0x8A000000);
I take it these are not material colors?

https://codereview.chromium.org/1157573012/diff/1/sky/sdk/lib/framework/compo...
sky/sdk/lib/framework/components2/radio.dart:43: paint.style = 0; //
SkPaint::FILL_STYLE;
Do we not have an enum?

[eseidel, 2015-06-04 23:51:59]

https://codereview.chromium.org/1157573012/diff/1/sky/engine/core/painting/Pa...
File sky/engine/core/painting/Paint.idl (right):

https://codereview.chromium.org/1157573012/diff/1/sky/engine/core/painting/Pa...
sky/engine/core/painting/Paint.idl:15: attribute float strokeWidth;
Do we do double now?

[abarth-chromium, 2015-06-04 23:58:38]

abarth@chromium.org changed reviewers:
- eseidel@chromium.org, mpcomplete@chromium.org

[abarth-chromium, 2015-06-04 23:58:39]

https://codereview.chromium.org/1157573012/diff/1/sky/sdk/lib/framework/compo...
File sky/sdk/lib/framework/components2/radio.dart (right):

https://codereview.chromium.org/1157573012/diff/1/sky/sdk/lib/framework/compo...
sky/sdk/lib/framework/components2/radio.dart:21: );
No need for this.

https://codereview.chromium.org/1157573012/diff/1/sky/sdk/lib/framework/compo...
sky/sdk/lib/framework/components2/radio.dart:23: static const sky.Size outerSize
= const sky.Size(outerRadius * 2, outerRadius * 2);
No need for this either.

https://codereview.chromium.org/1157573012/diff/1/sky/sdk/lib/framework/compo...
sky/sdk/lib/framework/components2/radio.dart:33: sky.Color color = highlight ?
new sky.Color(0xFF673AB7) : new sky.Color(0x8A000000);
const sky.Color

https://codereview.chromium.org/1157573012/diff/1/sky/sdk/lib/framework/fn2.dart
File sky/sdk/lib/framework/fn2.dart (right):

https://codereview.chromium.org/1157573012/diff/1/sky/sdk/lib/framework/fn2.d...
sky/sdk/lib/framework/fn2.dart:444: class CustomPaint extends
OneChildRenderObjectWrapper {
Can you add a TODO(jackson) to this class about needing a mechanism for marking
the RenderCustomPaint object as needing paint?

https://codereview.chromium.org/1157573012/diff/1/sky/sdk/lib/framework/fn2.d...
sky/sdk/lib/framework/fn2.dart:457: }
You probably want to implement a _remove similar to  SizeObserver to null out
the callback when this object is removed from the component hierarchy.

[abarth-chromium, 2015-06-05 00:07:56]

lgtm

[jackson, 2015-06-05 00:23:10]

https://codereview.chromium.org/1157573012/diff/1/sky/engine/core/painting/Pa...
File sky/engine/core/painting/Paint.idl (right):

https://codereview.chromium.org/1157573012/diff/1/sky/engine/core/painting/Pa...
sky/engine/core/painting/Paint.idl:9: const unsigned short FILL_STYLE           
= 0;
On 2015/06/04 23:50:54, eseidel wrote:
> If you're exposing these, can we use them in the callsites?
> 
> I think mpcomplete was having luck using enums too.

I'm going to rewrite this to work like TransferMode in a separate CL

https://codereview.chromium.org/1157573012/diff/1/sky/engine/core/painting/Pa...
sky/engine/core/painting/Paint.idl:15: attribute float strokeWidth;
On 2015/06/04 23:51:59, eseidel wrote:
> Do we do double now?

The Skia API is float

https://codereview.chromium.org/1157573012/diff/1/sky/sdk/lib/framework/compo...
File sky/sdk/lib/framework/components2/radio.dart (right):

https://codereview.chromium.org/1157573012/diff/1/sky/sdk/lib/framework/compo...
sky/sdk/lib/framework/components2/radio.dart:21: );
On 2015/06/04 23:58:39, abarth wrote:
> No need for this.

Done.

https://codereview.chromium.org/1157573012/diff/1/sky/sdk/lib/framework/compo...
sky/sdk/lib/framework/components2/radio.dart:23: static const sky.Size outerSize
= const sky.Size(outerRadius * 2, outerRadius * 2);
On 2015/06/04 23:58:39, abarth wrote:
> No need for this either.

Done.

https://codereview.chromium.org/1157573012/diff/1/sky/sdk/lib/framework/compo...
sky/sdk/lib/framework/components2/radio.dart:33: sky.Color color = highlight ?
new sky.Color(0xFF673AB7) : new sky.Color(0x8A000000);
On 2015/06/04 23:58:38, abarth wrote:
> const sky.Color

Done.

https://codereview.chromium.org/1157573012/diff/1/sky/sdk/lib/framework/compo...
sky/sdk/lib/framework/components2/radio.dart:43: paint.style = 0; //
SkPaint::FILL_STYLE;
On 2015/06/04 23:50:54, eseidel wrote:
> Do we not have an enum?

I am going to fix this in the next CL

https://codereview.chromium.org/1157573012/diff/1/sky/sdk/lib/framework/fn2.dart
File sky/sdk/lib/framework/fn2.dart (right):

https://codereview.chromium.org/1157573012/diff/1/sky/sdk/lib/framework/fn2.d...
sky/sdk/lib/framework/fn2.dart:444: class CustomPaint extends
OneChildRenderObjectWrapper {
On 2015/06/04 23:58:39, abarth wrote:
> Can you add a TODO(jackson) to this class about needing a mechanism for
marking
> the RenderCustomPaint object as needing paint?

Done.

https://codereview.chromium.org/1157573012/diff/1/sky/sdk/lib/framework/fn2.d...
sky/sdk/lib/framework/fn2.dart:457: }
On 2015/06/04 23:58:39, abarth wrote:
> You probably want to implement a _remove similar to  SizeObserver to null out
> the callback when this object is removed from the component hierarchy.

Done.

[eseidel, 2015-06-05 00:24:26]

eseidel@chromium.org changed reviewers:
+ eseidel@chromium.org

[eseidel, 2015-06-05 00:24:27]

lgtm

[jackson, 2015-06-05 00:24:43]

Committed patchset #7 (id:120001) manually as
3188c0d06b6e00686dce9de238874d8cf5c9aa19 (presubmit successful).