third_party/mojo/src/mojo/public/tools/dart_analyze.py - Issue 1157573002: Revert "Update mojo sdk to rev 1dc8a9a5db73d3718d99917fadf31f5fb2ebad4f"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/mojo/src/mojo/public/tools/dart_analyze.py

Issue 1157573002: Revert "Update mojo sdk to rev 1dc8a9a5db73d3718d99917fadf31f5fb2ebad4f" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/mojo/src/mojo/public/tools/bindings/mojom.gni ('k') | third_party/mojo/src/mojo/public/tools/dart_list_mojoms.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/mojo/src/mojo/public/tools/dart_analyze.py

diff --git a/third_party/mojo/src/mojo/public/tools/dart_analyze.py b/third_party/mojo/src/mojo/public/tools/dart_analyze.py

index 6e7dfc428bdabe5565b102e593df0880ed3164a2..b90cbef558dd3652c409b7767ca2fb32598cf85f 100755

--- a/third_party/mojo/src/mojo/public/tools/dart_analyze.py

+++ b/third_party/mojo/src/mojo/public/tools/dart_analyze.py

@@ -31,9 +31,6 @@ _IGNORED_PATTERNS = [

re.compile(r'.*is a part and can not|^Only libraries can be analyzed'),

# TODO: Remove this once dev SDK includes Uri.directory constructor.

re.compile(r'.*The class \'Uri\' does not have a constructor \'directory\''),

- # TODO: Remove this once Sky no longer generates this warning.

- # dartbug.com/22836

- re.compile(r'.*cannot both be unnamed'),

]

def _success(stamp_file):

@@ -69,7 +66,7 @@ def main(args):

cmd.extend(dart_files)

cmd.extend(args)

- cmd.append("--package-root=%s/packages" % temp_dir)

+ cmd.append("--package-root=%s" % temp_dir)

cmd.append("--fatal-warnings")

errors = 0