Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1141)

Issue 1157563011: Adding unbundled uiautomator jar from AOSP to third_party. (Closed)

Created:
5 years, 6 months ago by mikecase (-- gone --)
Modified:
5 years, 6 months ago
Reviewers:
perezju, cpu_(ooo_6.6-7.5), jbudorick, open-source-third-party-reviews, cjhopman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding unbundled uiautomator jar from AOSP to third_party. The unbundled uiautomator jar will allow us to run Android uiautomator tests via Android instrumentation. This will simplify our test runner code as we can remove uiautomator specific test runner code. Additionally, the instrumentation-based uiautomator is more up-to-date than the shell-based uiautomator embedded inside the Android platform that we are currently using. BUG=488573 Committed: https://crrev.com/c9eabe82c9045c2501cb86f4fc3cf8c58e7b9887 Cr-Commit-Position: refs/heads/master@{#334428}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 #

Patch Set 4 : Updated .gitignore #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -0 lines) Patch
M .gitignore View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/ub-uiautomator/BUILD.gn View 1 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/ub-uiautomator/LICENSE View 1 1 chunk +202 lines, -0 lines 0 comments Download
A third_party/ub-uiautomator/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/ub-uiautomator/README.chromium View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/ub-uiautomator/ub-uiautomator.gyp View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
mikecase (-- gone --)
+jbudorick@ and +perezju@ because they are OWNERS. +cjhopman to review third/ub-uiautomator/BUILD.gn and ub-uiautomator.gyp +open-source-third-party-reviews to ...
5 years, 6 months ago (2015-06-03 00:57:20 UTC) #2
cjhopman
lgtm
5 years, 6 months ago (2015-06-04 20:41:45 UTC) #3
jbudorick
lgtm
5 years, 6 months ago (2015-06-04 21:49:50 UTC) #4
perezju
lgtm
5 years, 6 months ago (2015-06-05 08:17:07 UTC) #5
mikecase (-- gone --)
Just need open-source-third-party-reviews to take a look at this now. Thanks.
5 years, 6 months ago (2015-06-08 17:58:09 UTC) #6
mikecase (-- gone --)
Got an LGTM from open-source-third-party-reviews via email. Adding cpu@ for review of third_party/
5 years, 6 months ago (2015-06-10 23:12:20 UTC) #8
cpu_(ooo_6.6-7.5)
lgtm
5 years, 6 months ago (2015-06-12 21:24:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157563011/60001
5 years, 6 months ago (2015-06-15 17:00:03 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-15 18:58:07 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 18:58:58 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c9eabe82c9045c2501cb86f4fc3cf8c58e7b9887
Cr-Commit-Position: refs/heads/master@{#334428}

Powered by Google App Engine
This is Rietveld 408576698