Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2096)

Unified Diff: Source/devtools/front_end/screencast/ScreencastView.js

Issue 1157563008: [KeyboardEvent] DOM |Key| support in devTools (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/protocol.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/screencast/ScreencastView.js
diff --git a/Source/devtools/front_end/screencast/ScreencastView.js b/Source/devtools/front_end/screencast/ScreencastView.js
index 4d3749b1b410d6b822773b92815f4c1efa2b4c31..1776e7fe509793772575acbb72780bb697e5ede8 100644
--- a/Source/devtools/front_end/screencast/ScreencastView.js
+++ b/Source/devtools/front_end/screencast/ScreencastView.js
@@ -278,8 +278,20 @@ WebInspector.ScreencastView.prototype = {
}
var text = event.type === "keypress" ? String.fromCharCode(event.charCode) : undefined;
- this._target.inputAgent().dispatchKeyEvent(type, this._modifiersForEvent(event), event.timeStamp / 1000, text, text ? text.toLowerCase() : undefined,
- event.keyIdentifier, event.code, event.keyCode /* windowsVirtualKeyCode */, event.keyCode /* nativeVirtualKeyCode */, false, false, false);
+ this._target.inputAgent().dispatchKeyEvent({
dgozman 2015/06/02 12:28:01 This should be an object literal: { type: type, mo
Habib Virji 2015/06/02 12:33:45 Done.
+ type,
+ this._modifiersForEvent(event),
+ event.timeStamp / 1000,
+ text,
+ text ? text.toLowerCase() : undefined,
+ event.keyIdentifier,
+ event.code,
+ event.key,
+ event.keyCode,
+ event.keyCode,
+ false,
+ false,
+ false});
event.consume();
this._canvasElement.focus();
},
« no previous file with comments | « no previous file | Source/devtools/protocol.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698