Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1157563008: [KeyboardEvent] DOM |Key| support in devTools (Closed)

Created:
5 years, 6 months ago by Habib Virji
Modified:
5 years, 6 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[KeyboardEvent] DOM |Key| support in devTools This updates protocol.json with additional parameter DomKey. BUG=227231 R=dgozman, pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196383

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated dispatchKeyEvent to be object literal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M Source/devtools/front_end/screencast/ScreencastView.js View 1 1 chunk +14 lines, -2 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Habib Virji
Had dependency on the chromium side: https://codereview.chromium.org/1143073007/ This commit is based on the comment from ...
5 years, 6 months ago (2015-06-02 12:14:34 UTC) #1
dgozman
https://codereview.chromium.org/1157563008/diff/1/Source/devtools/front_end/screencast/ScreencastView.js File Source/devtools/front_end/screencast/ScreencastView.js (right): https://codereview.chromium.org/1157563008/diff/1/Source/devtools/front_end/screencast/ScreencastView.js#newcode281 Source/devtools/front_end/screencast/ScreencastView.js:281: this._target.inputAgent().dispatchKeyEvent({ This should be an object literal: { type: ...
5 years, 6 months ago (2015-06-02 12:28:01 UTC) #2
Habib Virji
Thanks updated. https://codereview.chromium.org/1157563008/diff/1/Source/devtools/front_end/screencast/ScreencastView.js File Source/devtools/front_end/screencast/ScreencastView.js (right): https://codereview.chromium.org/1157563008/diff/1/Source/devtools/front_end/screencast/ScreencastView.js#newcode281 Source/devtools/front_end/screencast/ScreencastView.js:281: this._target.inputAgent().dispatchKeyEvent({ On 2015/06/02 12:28:01, dgozman wrote: > ...
5 years, 6 months ago (2015-06-02 12:33:45 UTC) #3
dgozman
lgtm
5 years, 6 months ago (2015-06-02 12:35:45 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157563008/20001
5 years, 6 months ago (2015-06-02 16:42:03 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-02 17:52:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157563008/20001
5 years, 6 months ago (2015-06-03 08:37:27 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 08:40:58 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196383

Powered by Google App Engine
This is Rietveld 408576698