Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 1157563002: Revert of Add ref-count on RenderViewHost for each new RenderFrameProxyHost. (Closed)

Created:
5 years, 7 months ago by Steven Holte
Modified:
5 years, 7 months ago
Reviewers:
Charlie Reis, nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add ref-count on RenderViewHost for each new RenderFrameProxyHost. (patchset #4 id:60001 of https://codereview.chromium.org/1150793002/) Reason for revert: It looks like the new browser test fails on Win8 aura https://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/30026/steps/content_browsertests/logs/RenderFrameHostManagerTest.CleanupOnCrossProcessNavigation Original issue's description: > Add ref-count on RenderViewHost for each new RenderFrameProxyHost. > > Currently, only RenderFrameHosts are ref-counting the associated RenderViewHost. > Since it is possible to have a RenderViewHost with no associated RenderFrameHost > (for example a cross-process window opener/openee relationship), it should > be taken into account that the associated RenderFrameProxyHost is also > a ref-counting the RenderViewHost. > The goal of this CL is to allow for that, even though it isn't currently > the case. It is a small step towards removing swapped out RenderFrameHosts. > > BUG=357747 > > Committed: https://crrev.com/8542185bbb9fd0c0e7d0240c64403d2e4cea39f2 > Cr-Commit-Position: refs/heads/master@{#331016} TBR=creis@chromium.org,nasko@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=357747 Committed: https://crrev.com/72e13b2f01beb6105c6a74b66aa92bdc6d553a8e Cr-Commit-Position: refs/heads/master@{#331041}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -93 lines) Patch
M content/browser/frame_host/frame_tree.h View 1 chunk +4 lines, -5 lines 0 comments Download
M content/browser/frame_host/frame_tree.cc View 2 chunks +14 lines, -13 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 4 chunks +4 lines, -11 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 3 chunks +0 lines, -38 lines 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.h View 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.cc View 2 chunks +1 line, -6 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 2 chunks +3 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Steven Holte
Created Revert of Add ref-count on RenderViewHost for each new RenderFrameProxyHost.
5 years, 7 months ago (2015-05-22 01:24:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157563002/1
5 years, 7 months ago (2015-05-22 01:26:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-22 01:30:57 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 01:31:47 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72e13b2f01beb6105c6a74b66aa92bdc6d553a8e
Cr-Commit-Position: refs/heads/master@{#331041}

Powered by Google App Engine
This is Rietveld 408576698