Add fetch recipes for dart and dartium

Add fetch recipes for dart and dartium

BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295572

[ricow1, 2015-05-28 14:49:37]

ricow@google.com changed reviewers:
+ phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2015-05-29 13:48:49]

LGTM

[ricow1, 2015-06-01 12:05:02]

The CQ bit was checked by ricow@google.com

[commit-bot: I haz the power, 2015-06-01 12:05:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1157543005/1

[commit-bot: I haz the power, 2015-06-01 12:07:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-01 12:07:54]

Presubmit check for 1157543005-1 failed and returned exit status 1.

Running presubmit commit checks ...
Initialized empty Git repository in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/_rietveld/.git/
Updating origin
From https://chromium.googlesource.com/infra/infra
 * [new branch]      deployed   -> origin/deployed
 * [new branch]      infra/config -> origin/infra/config
 * [new branch]      master     -> origin/master
From https://chromium.googlesource.com/infra/infra
 * branch            master     -> FETCH_HEAD
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    depot_tools/recipes/dart.py
    depot_tools/recipes/dartium.py

Presubmit checks took 154.5s to calculate.

[ricow1, 2015-06-01 12:12:56]

ricow@google.com changed reviewers:
+ iannucci@chromium.org

[ricow1, 2015-06-01 12:12:57]

+Robert since Pawel is not in owners

[ricow1, 2015-06-02 12:07:45]

ping

[ricow1, 2015-06-09 06:00:08]

On 2015/06/02 12:07:45, ricow1 wrote:
> ping

pong

[iannucci, 2015-06-09 06:13:30]

lgtm, though I don't think dartium will have the intended effect... I think
you'll actually want to have a deps entry for src, no?

[ricow1, 2015-06-09 06:20:53]

On 2015/06/09 06:13:30, iannucci wrote:
> lgtm, though I don't think dartium will have the intended effect... I think
> you'll actually want to have a deps entry for src, no?

Not really, it is a little hackish, to avoid having to do multiple repo changes
to often we actually have the dartium DEPS file in the dart repo:
https://github.com/dart-lang/sdk/blob/master/tools/deps/dartium.deps/DEPS

Now, we don't want two checkouts of the sdk repo (we would need it for the DEPS
file, and for src/dart where the bindings are pointing at). The DEPS file
actually contains a value for src, so it will checkout of the dartium branch of
chrome there (and pull all the normal chrome dependencies by including the
DEPS.chromium file):
https://github.com/dart-lang/sdk/blob/master/tools/deps/dartium.deps/DEPS.chr...

Since we give the initial checkout the name src/dart, that is where gclient will
checkout out the url we point at (https://github.com/dart-lang/sdk.git) - and
the deps file in there tools/deps/dartium.deps/DEPS will then pull in src). Note
that we have pinned dependencies for the dartium branch of chrome, we explicitly
roll that and run this against TOT https://github.com/dart-lang/sdk.git

[ricow1, 2015-06-09 06:40:50]

The CQ bit was checked by ricow@google.com

[commit-bot: I haz the power, 2015-06-09 06:45:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-09 06:45:02]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[ricow1, 2015-06-09 06:50:51]

The CQ bit was checked by ricow@google.com

[commit-bot: I haz the power, 2015-06-09 06:55:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-09 06:55:03]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[iannucci, 2015-06-09 07:12:12]

On 2015/06/09 06:55:03, commit-bot: I haz the power wrote:
> Commit queue rejected this change because it did not recognize the base URL.
> Please commit your change manually.

hm... that's weird. I think it's because you didn't run 'git auto-svn' in
depot_tools, so it thinks that it's a real git repo (the base URL is really SVN
still (yeah yeah, we know)).

[ricow1, 2015-06-09 07:53:05]

On 2015/06/09 07:12:12, iannucci wrote:
> On 2015/06/09 06:55:03, commit-bot: I haz the power wrote:
> > Commit queue rejected this change because it did not recognize the base URL.
> > Please commit your change manually.
> 
> hm... that's weird. I think it's because you didn't run 'git auto-svn' in
> depot_tools, so it thinks that it's a real git repo (the base URL is really
SVN
> still (yeah yeah, we know)).

I think it is more weird that on the first cq try it actually ran the presubmit
script and found that Pawel was not in owners - it did not on the second cq run

[ricow1, 2015-06-09 07:53:16]

The CQ bit was checked by ricow@google.com

[ricow1, 2015-06-09 07:53:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org, phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/1157543005/#ps20001
(title: "auto svn")

[commit-bot: I haz the power, 2015-06-09 07:53:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1157543005/20001

[commit-bot: I haz the power, 2015-06-09 07:56:21]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295572