Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: src/assembler.h

Issue 1157543004: Debugger: PreservePositionScope should clear positions inside the scope. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: only break at inline caches if it owns a statement position. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/debug.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 1094 matching lines...) Expand 10 before | Expand all | Expand 10 after
1105 friend class PreservePositionScope; 1105 friend class PreservePositionScope;
1106 1106
1107 DISALLOW_COPY_AND_ASSIGN(PositionsRecorder); 1107 DISALLOW_COPY_AND_ASSIGN(PositionsRecorder);
1108 }; 1108 };
1109 1109
1110 1110
1111 class PreservePositionScope BASE_EMBEDDED { 1111 class PreservePositionScope BASE_EMBEDDED {
1112 public: 1112 public:
1113 explicit PreservePositionScope(PositionsRecorder* positions_recorder) 1113 explicit PreservePositionScope(PositionsRecorder* positions_recorder)
1114 : positions_recorder_(positions_recorder), 1114 : positions_recorder_(positions_recorder),
1115 saved_state_(positions_recorder->state_) {} 1115 saved_state_(positions_recorder->state_) {
1116 // Reset positions so that previous ones do not accidentally get
1117 // recorded within this scope.
1118 positions_recorder->state_ = PositionState();
1119 }
1116 1120
1117 ~PreservePositionScope() { 1121 ~PreservePositionScope() {
1118 positions_recorder_->state_ = saved_state_; 1122 positions_recorder_->state_ = saved_state_;
1119 } 1123 }
1120 1124
1121 private: 1125 private:
1122 PositionsRecorder* positions_recorder_; 1126 PositionsRecorder* positions_recorder_;
1123 const PositionState saved_state_; 1127 const PositionState saved_state_;
1124 1128
1125 DISALLOW_COPY_AND_ASSIGN(PreservePositionScope); 1129 DISALLOW_COPY_AND_ASSIGN(PreservePositionScope);
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
1163 NullCallWrapper() { } 1167 NullCallWrapper() { }
1164 virtual ~NullCallWrapper() { } 1168 virtual ~NullCallWrapper() { }
1165 virtual void BeforeCall(int call_size) const { } 1169 virtual void BeforeCall(int call_size) const { }
1166 virtual void AfterCall() const { } 1170 virtual void AfterCall() const { }
1167 }; 1171 };
1168 1172
1169 1173
1170 } } // namespace v8::internal 1174 } } // namespace v8::internal
1171 1175
1172 #endif // V8_ASSEMBLER_H_ 1176 #endif // V8_ASSEMBLER_H_
OLDNEW
« no previous file with comments | « no previous file | src/debug.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698