Issue 11575050: Fix tracing for gpu/ directory in NaCl

Issue 11575050: Fix tracing for gpu/ directory in NaCl (Closed)

Created:
8 years ago by jbauman

Modified:
8 years ago

Reviewers:
bbudge, apatrick_chromium

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix tracing for gpu/ directory in NaCl NACL_PPAPI_IPC_PROXY isn't defined when compiling the .cc files for the IPC proxy, so instead make a NACL_PPAPI_SRPC_PROXY variable that's used only when compiling the SRPC proxy and use that to determine which trace macros to use. BUG=93839 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173648

Patch Set 1 #

Patch Set 2 : remove unnecessary changes #

Total comments: 1

Patch Set 3 : change comment #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
M	gpu/command_buffer/client/ref_counted.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/common/trace_event.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy_untrusted.gyp	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

apatrick_chromium

lgtm https://codereview.chromium.org/11575050/diff/3001/gpu/command_buffer/common/trace_event.h File gpu/command_buffer/common/trace_event.h (right): https://codereview.chromium.org/11575050/diff/3001/gpu/command_buffer/common/trace_event.h#newcode30 gpu/command_buffer/common/trace_event.h:30: #endif // __native_client__ Nit: update or delete comment.

8 years ago (2012-12-17 21:33:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/11575050/1006

8 years ago (2012-12-17 21:46:26 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/11575050/1006

8 years ago (2012-12-18 01:13:35 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/11575050/1006

8 years ago (2012-12-18 01:58:57 UTC) #6

Message was sent while issue was closed.

Change committed as 173648

Expand Messages | Collapse Messages