Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(29)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1157443004: Limit <link rel=preconnect> to the HTTP family (Closed)

Created:
4 years, 11 months ago by Yoav Weiss
Modified:
4 years, 11 months ago
Reviewers:
Mike West
CC:
blink-reviews, gavinp+prerender_chromium.org, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Limit <link rel=preconnect> to the HTTP family As pointed out during the review of https://codereview.chromium.org/1152043005/ it is better to limit preconnect only to connections of the HTTP family. This CL performs that change for parsed (rather than preloaded) Link elements. BUG=450682 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196411

Patch Set 1 #

Total comments: 1

Patch Set 2 : Moved test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
A + LayoutTests/fast/dom/HTMLLinkElement/link-preconnect-nonhttp.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
A LayoutTests/fast/dom/HTMLLinkElement/link-preconnect-nonhttp-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/LinkLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Yoav Weiss
4 years, 11 months ago (2015-06-03 10:09:29 UTC) #2
Mike West
LGTM % test comment. https://codereview.chromium.org/1157443004/diff/1/LayoutTests/fast/dom/HTMLLinkElement/link-preconnect-valid.html File LayoutTests/fast/dom/HTMLLinkElement/link-preconnect-valid.html (right): https://codereview.chromium.org/1157443004/diff/1/LayoutTests/fast/dom/HTMLLinkElement/link-preconnect-valid.html#newcode11 LayoutTests/fast/dom/HTMLLinkElement/link-preconnect-valid.html:11: <link rel="preconnect" href="ws://prefetch1.wut.com.test"> Can you ...
4 years, 11 months ago (2015-06-03 11:50:01 UTC) #3
Yoav Weiss
On 2015/06/03 11:50:01, Mike West wrote: > LGTM % test comment. > > https://codereview.chromium.org/1157443004/diff/1/LayoutTests/fast/dom/HTMLLinkElement/link-preconnect-valid.html > ...
4 years, 11 months ago (2015-06-03 14:16:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157443004/20001
4 years, 11 months ago (2015-06-03 14:17:16 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2015-06-03 15:53:22 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196411

Powered by Google App Engine
This is Rietveld 408576698