sky/sdk/lib/framework/layout2.dart - Issue 1157433006: Remove bogus assert in layout()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/framework/layout2.dart

Issue 1157433006: Remove bogus assert in layout() (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/sdk/lib/framework/layout2.dart

diff --git a/sky/sdk/lib/framework/layout2.dart b/sky/sdk/lib/framework/layout2.dart

index ac060ab2dfea09b2a2507263ab2cae14eb10a359..f8b9ecff652daae63b81ebf5aede87d5ef8c67b7 100644

--- a/sky/sdk/lib/framework/layout2.dart

+++ b/sky/sdk/lib/framework/layout2.dart

@@ -125,7 +125,7 @@ abstract class RenderNode extends AbstractNode {

print(stack);

return;

}

- assert(!_needsLayout); // check that the relayout() method marked us "not dirty"

+ _needsLayout = false;

}

void layout(dynamic constraints, { bool parentUsesSize: false }) {

RenderNode relayoutSubtreeRoot;

« no previous file with comments | « no previous file | no next file » | no next file with comments »