Issue 11574047: overscroll: Send all gesture-events to the gesture-event filter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11574047: overscroll: Send all gesture-events to the gesture-event filter. (Closed)

Created:
8 years ago by sadrul

Modified:
8 years ago

Reviewers:
rjkroege

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

overscroll: Send all gesture-events to the gesture-event filter. The gesture-event filter should receive all gesture events (irrespective of their source device). The overscroll-controller was erroneously sending it gesture-events only from the touch-screen, thus causing the gesture-event filter to receive ACKs for gesture events it wasn't expecting, resulting in crashes. BUG=165207, 165205 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173263

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : add a test. #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -33 lines)			Patch
	M	content/browser/renderer_host/overscroll_controller.cc	View	1	4 chunks	+11 lines, -33 lines	0 comments	Download
	M	content/browser/renderer_host/render_widget_host_unittest.cc	View	1 2	1 chunk	+42 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Thanks. Added a test. Sent to the trybots.

Expand Messages | Collapse Messages