Intel VTune integration for V8/D8

src/third_party/vtune/v8vtune.gyp

Index: src/third_party/vtune/v8vtune.gyp
===================================================================
--- src/third_party/vtune/v8vtune.gyp	(revision 0)
+++ src/third_party/vtune/v8vtune.gyp	(revision 0)
@@ -0,0 +1,75 @@
+# Copyright 2012 the V8 project authors. All rights reserved.

[Jakob Kummerow, 2013/03/25 17:10:43]

nit: 2013

+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are
+# met:
+#
+#     * Redistributions of source code must retain the above copyright
+#       notice, this list of conditions and the following disclaimer.
+#     * Redistributions in binary form must reproduce the above
+#       copyright notice, this list of conditions and the following
+#       disclaimer in the documentation and/or other materials provided
+#       with the distribution.
+#     * Neither the name of Google Inc. nor the names of its
+#       contributors may be used to endorse or promote products derived
+#       from this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+{
+  'includes': ['../../../build/common.gypi'],
+  'variables': {
+    'console%': '',

[Jakob Kummerow, 2013/03/25 17:10:43]

I don't see what you need this for.

+  },
+  'targets': [
+    {
+      'target_name': 'v8_vtune',
+      'type': 'static_library',
+      'dependencies': [
+        '../../../tools/gyp/v8.gyp:v8_base',
+      ],
+      'include_dirs+': [
+        '../../../src',

[Jakob Kummerow, 2013/03/25 17:10:43]

I don't think you need this either, since you have the full path to v8.h at the
place where you #include it. Does the build work when you remove this
'include_dirs+' section? (You'll probably have to update vtune-jit.cc to include
the vtune-related headers without paths.)

+      ],
+      'sources': [
+        '../../../src/third_party/vtune/ittnotify_config.h',

[Jakob Kummerow, 2013/03/25 17:10:43]

I don't think there's a need for this weird path specification. Since the files
are in the same directory as this .gyp file, you can just list them without
path.

+        '../../../src/third_party/vtune/ittnotify_types.h',
+        '../../../src/third_party/vtune/jitprofiling.cc',
+        '../../../src/third_party/vtune/jitprofiling.h',
+        '../../../src/third_party/vtune/v8-vtune.h',
+        '../../../src/third_party/vtune/vtune-jit.cc',
+        '../../../src/third_party/vtune/vtune-jit.h',
+      ],
+      'conditions': [
+        ['want_separate_host_toolset==1', {
+          'toolsets': ['host', 'target'],

[Jakob Kummerow, 2013/03/25 17:10:43]

Why would you want to build the vtune lib for the host toolset?

+        }, {
+          'toolsets': ['target'],
+        }],
+        ['component=="shared_library"', {
+          'defines': [
+            'BUILDING_V8_SHARED',

[Jakob Kummerow, 2013/03/25 17:10:43]

As far as I can see you're not using either of these defines. So why define
them?

+            'V8_SHARED',
+          ],
+        }],
+      ],
+      'direct_dependent_settings': {
+        'defines': ['ENABLE_VTUNE_JIT_INTERFACE',],
+        'conditions': [
+          ['OS != "win"', {
+            'libraries': ['-ldl',],
+          }],   
+        ],
+      },
+    },
+  ],
+}