Intel VTune integration for V8/D8

src/third_party/vtune/v8-vtune.h

Index: src/third_party/vtune/v8-vtune.h
===================================================================
--- src/third_party/vtune/v8-vtune.h	(revision 0)
+++ src/third_party/vtune/v8-vtune.h	(revision 0)
@@ -0,0 +1,102 @@
+/*
+   This file is provided under a dual BSD/GPLv2 license.  When using or
+   redistributing this file, you may do so under either license.
+ 
+   GPL LICENSE SUMMARY
+ 
+   Copyright(c) 2005-2012 Intel Corporation. All rights reserved.
+ 
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of version 2 of the GNU General Public License as
+   published by the Free Software Foundation.
+ 
+   This program is distributed in the hope that it will be useful, but
+   WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   General Public License for more details.
+ 
+   You should have received a copy of the GNU General Public License
+   along with this program; if not, write to the Free Software
+   Foundation, Inc., 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
+   The full GNU General Public License is included in this distribution
+   in the file called LICENSE.GPL.
+ 
+   Contact Information:
+   http://software.intel.com/en-us/articles/intel-vtune-amplifier-xe/
+ 
+   BSD LICENSE
+ 
+   Copyright(c) 2005-2012 Intel Corporation. All rights reserved.
+   All rights reserved.
+ 
+   Redistribution and use in source and binary forms, with or without
+   modification, are permitted provided that the following conditions
+   are met:
+ 
+     * Redistributions of source code must retain the above copyright
+       notice, this list of conditions and the following disclaimer.
+     * Redistributions in binary form must reproduce the above copyright
+       notice, this list of conditions and the following disclaimer in
+       the documentation and/or other materials provided with the
+       distribution.
+     * Neither the name of Intel Corporation nor the names of its
+       contributors may be used to endorse or promote products derived
+       from this software without specific prior written permission.
+ 
+   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+#ifndef V8_VTUNE_H_
+#define V8_VTUNE_H_
+
+
+#ifdef _WIN32
+// Setup for Windows DLL export/import. See v8.h in the include folder for
+// information on how to build/use V8 as a DLL.
+#if defined(BUILDING_V8_SHARED) && defined(USING_V8_SHARED)
+#error both BUILDING_V8_SHARED and USING_V8_SHARED are set - please check the\
+  build configuration to ensure that at most one of these is set
+#endif
+
+#ifdef BUILDING_V8_SHARED
+#define V8EXPORT __declspec(dllexport)

[danno, 2013/03/07 14:19:20]

I finally see what you are trying to accomplish with this #define EXPORT, and
it's actually different from what I originally proposed and the way they I think
your code should be packaged.

Fundamentally, vtune support should be provided as part of the embedder, not
part of V8.

I envisioned that that vtune support (i.e. all the stuff in the
third_party/vtune library) would be build into a lib, i.e. libvtunev8.a. This
lib would be included into the d8 build (or Chromium), which calls
InitilizeVtuneForV8. InitilizeVtuneForV8 doesn't need to be exported, since it's
part of a .a library. All the calls it needs from V8 are already exported, so no
extra V8EXPORT is needed anywhere.

The packaging I describe allows a complete decoupling between V8 and Vtune,
which (i.e. no VTune code ever needs to be in V8's library or shared lib.

+#elif USING_V8_SHARED
+#define V8EXPORT __declspec(dllimport)
+#else
+#define V8EXPORT
+#endif
+
+#else  // _WIN32
+
+// Setup for Linux shared library export. See v8.h in the include for
+// information on how to build/use V8 as shared library.
+#if defined(__GNUC__) && ((__GNUC__ >= 4) || \
+    (__GNUC__ == 3 && __GNUC_MINOR__ >= 3)) && defined(V8_SHARED)
+#define V8EXPORT __attribute__ ((visibility("default")))
+#else
+#define V8EXPORT
+#endif
+
+#endif  // _WIN32
+
+namespace vTune {
+
+void V8EXPORT InitilizeVtuneForV8();
+
+}  // namespace vTune
+
+
+#undef V8EXPORT
+
+
+#endif  // V8_VTUNE_H_
+