Intel VTune integration for V8/D8

src/third_party/vtune/vtune-jit.h

+/*
+   This file is provided under a dual BSD/GPLv2 license.  When using or
+   redistributing this file, you may do so under either license.
+ 
+   GPL LICENSE SUMMARY
+ 
+   Copyright(c) 2005-2012 Intel Corporation. All rights reserved.
+ 
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of version 2 of the GNU General Public License as
+   published by the Free Software Foundation.
+ 
+   This program is distributed in the hope that it will be useful, but
+   WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   General Public License for more details.
+ 
+   You should have received a copy of the GNU General Public License
+   along with this program; if not, write to the Free Software
+   Foundation, Inc., 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
+   The full GNU General Public License is included in this distribution
+   in the file called LICENSE.GPL.
+ 
+   Contact Information:
+   http://software.intel.com/en-us/articles/intel-vtune-amplifier-xe/
+ 
+   BSD LICENSE
+ 
+   Copyright(c) 2005-2012 Intel Corporation. All rights reserved.
+   All rights reserved.
+ 
+   Redistribution and use in source and binary forms, with or without
+   modification, are permitted provided that the following conditions
+   are met:
+ 
+     * Redistributions of source code must retain the above copyright
+       notice, this list of conditions and the following disclaimer.
+     * Redistributions in binary form must reproduce the above copyright
+       notice, this list of conditions and the following disclaimer in
+       the documentation and/or other materials provided with the
+       distribution.
+     * Neither the name of Intel Corporation nor the names of its
+       contributors may be used to endorse or promote products derived
+       from this software without specific prior written permission.
+ 
+   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+#ifndef V8_VTUNE_JIT_H_
+#define V8_VTUNE_JIT_H_
+
+#include "jitprofiling.h"
+#include "../../v8.h"
+
+#define VTUNERUNNING (iJIT_IsProfilingActive() == iJIT_SAMPLING_ON)

[danno, 2013/02/25 20:25:38]

If this is an interface file with the public API for using VTune with V8, then
internal stuff (like this?) should not be in the same header, just like in V8 we
separate the public header from internal headers.

+
+#ifdef _WIN32

[danno, 2013/02/25 20:25:38]

Why do you need to define these?  ../../include/v8.h should already make sure
the V8EXPORT is defined correctly and check conflicting build configuration.

+// Setup for Windows DLL export/import. See v8.h in the include folder for
+// information on how to build/use V8 as a DLL.
+#if defined(BUILDING_V8_SHARED) && defined(USING_V8_SHARED)
+#error both BUILDING_V8_SHARED and USING_V8_SHARED are set - please check the\
+  build configuration to ensure that at most one of these is set
+#endif
+
+#ifdef BUILDING_V8_SHARED
+#define V8EXPORT __declspec(dllexport)
+#elif USING_V8_SHARED
+#define V8EXPORT __declspec(dllimport)
+#else
+#define V8EXPORT
+#endif
+
+#else  // _WIN32
+
+// Setup for Linux shared library export. See v8.h in the include for
+// information on how to build/use V8 as shared library.
+#if defined(__GNUC__) && ((__GNUC__ >= 4) || \
+    (__GNUC__ == 3 && __GNUC_MINOR__ >= 3)) && defined(V8_SHARED)
+#define V8EXPORT __attribute__ ((visibility("default")))
+#else
+#define V8EXPORT
+#endif
+
+#endif  // _WIN32
+
+namespace v8 {

[danno, 2013/02/25 20:25:38]

I don't see a reason why all of this should be inside the V8/V8::internal
namespace. How about creating a "vTune" or "VTune" namespace which directly
contains a method "InitializeVTuneForV8"?

+
+class V8EXPORT VTuneInitilizer {

[danno, 2013/02/25 20:25:38]

Any particular reason to wrap this is a class? V8EXPORT should work directly on
the initialization method.

+ public:
+  static void initilizeVtune();
+};
+
+namespace internal {
+
+// This class is used to record the JITted code position info for JIT
+// code profiling.
+class JITCodeLineInfo : public Malloced {

[danno, 2013/02/25 20:25:38]

Is there any reason that this needs to be in the header at all? It is an
implementation detail of how VTune tracks JITCodeLineInfos. Should be 

+ public:
+  JITCodeLineInfo() : line_num_info_(10) { }
+
+  void SetPosition(intptr_t pc, int pos) {
+    AddCodeLineInfo(LineNumInfo(pc, pos));
+  }
+
+  struct LineNumInfo {
+    LineNumInfo(intptr_t pc, int pos)
+        : pc_(pc), pos_(pos) { }
+
+    intptr_t pc_;
+    int pos_;
+  };
+
+  List<LineNumInfo>* GetLineNumInfo() {
+    return &line_num_info_;
+  }
+
+ private:
+  void AddCodeLineInfo(const LineNumInfo& line_info) {
+    line_num_info_.Add(line_info);
+  }
+  List<LineNumInfo> line_num_info_;
+};
+
+class VTUNEJITInterface: public AllStatic {
+ public:
+  static void event_handler(const v8::JitCodeEvent* event);
+
+ private:
+  static Mutex* vtunemutex_;
+};
+
+
+} }  // namespace v8::internal
+
+
+#undef V8EXPORT

[danno, 2013/02/25 20:25:38]

I don't think you should mess with V8EXPORT explicitly, especially in a "public"
header that is providing the API to vtune-jit.

+
+
+#endif  // V8_VTUNE_JIT_H_
+