Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/objects.cc

Issue 11574027: Use direct jump and call instruction for X64 when the deoptimization entries are in the code range (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/assembler.h ('k') | src/x64/assembler-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 8606 matching lines...) Expand 10 before | Expand all | Expand 10 after
8617 } else if (mode == RelocInfo::GLOBAL_PROPERTY_CELL) { 8617 } else if (mode == RelocInfo::GLOBAL_PROPERTY_CELL) {
8618 Handle<JSGlobalPropertyCell> cell = it.rinfo()->target_cell_handle(); 8618 Handle<JSGlobalPropertyCell> cell = it.rinfo()->target_cell_handle();
8619 it.rinfo()->set_target_cell(*cell, SKIP_WRITE_BARRIER); 8619 it.rinfo()->set_target_cell(*cell, SKIP_WRITE_BARRIER);
8620 } else if (RelocInfo::IsCodeTarget(mode)) { 8620 } else if (RelocInfo::IsCodeTarget(mode)) {
8621 // rewrite code handles in inline cache targets to direct 8621 // rewrite code handles in inline cache targets to direct
8622 // pointers to the first instruction in the code object 8622 // pointers to the first instruction in the code object
8623 Handle<Object> p = it.rinfo()->target_object_handle(origin); 8623 Handle<Object> p = it.rinfo()->target_object_handle(origin);
8624 Code* code = Code::cast(*p); 8624 Code* code = Code::cast(*p);
8625 it.rinfo()->set_target_address(code->instruction_start(), 8625 it.rinfo()->set_target_address(code->instruction_start(),
8626 SKIP_WRITE_BARRIER); 8626 SKIP_WRITE_BARRIER);
8627 #if defined(V8_TARGET_ARCH_X64)
danno 2013/02/06 15:00:38 I would very much like to avoid having platform #i
haitao.feng 2013/02/07 05:08:05 Done.
8628 } else if (RelocInfo::IsRuntimeEntry(mode)) {
8629 // rewrite runtime entries in optimized codes to direct
8630 // pointers to the entry
8631 Address p = it.rinfo()->target_runtime_entry(origin);
8632 it.rinfo()->set_target_address(p, SKIP_WRITE_BARRIER);
8633 #endif
8627 } else { 8634 } else {
8628 it.rinfo()->apply(delta); 8635 it.rinfo()->apply(delta);
8629 } 8636 }
8630 } 8637 }
8631 CPU::FlushICache(instruction_start(), instruction_size()); 8638 CPU::FlushICache(instruction_start(), instruction_size());
8632 } 8639 }
8633 8640
8634 8641
8635 // Locate the source position which is closest to the address in the code. This 8642 // Locate the source position which is closest to the address in the code. This
8636 // is using the source position information embedded in the relocation info. 8643 // is using the source position information embedded in the relocation info.
(...skipping 5218 matching lines...) Expand 10 before | Expand all | Expand 10 after
13855 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER); 13862 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER);
13856 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER); 13863 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER);
13857 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER); 13864 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER);
13858 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER); 13865 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER);
13859 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER); 13866 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER);
13860 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER); 13867 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER);
13861 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER); 13868 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER);
13862 } 13869 }
13863 13870
13864 } } // namespace v8::internal 13871 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/assembler.h ('k') | src/x64/assembler-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698