Move parsing of TRYSERVER_* so options.root is not overwritten

trychange.py

Index: trychange.py
===================================================================
--- trychange.py	(revision 172880)
+++ trychange.py	(working copy)
@@ -168,7 +168,8 @@
   def AutomagicalSettings(self):
     """Determines settings based on supported code review and checkout tools.
     """
-    # Try to find gclient or repo root first.
+    self._GclStyleSettings()

[M-A Ruel, 2012/12/13 23:58:06]

I'm pretty sure there was a reason for it to be done in the other order.

But I can't recall.

lgtm, just be prepared to revert in case of tool breakage reports.

[kjellander_chromium, 2012/12/18 08:52:15]

I think it's pretty safe to move it. 
All the code below that was added before the parsing was moved there in
https://codereview.chromium.org/8174009
I guess since no on seems to use TRYSERVER_ROOT this problem was not noticed.


On 2012/12/13 23:58:06, Marc-Antoine Ruel wrote:

+    # Try to find gclient or repo root.
     if not self.options.no_search:
       self.toplevel_root = gclient_utils.FindGclientRoot(self.checkout_root)
       if self.toplevel_root:
@@ -185,8 +186,6 @@
         self.options.root = gclient_utils.PathDifference(self.toplevel_root,
                                                          self.checkout_root)
 
-    self._GclStyleSettings()
-
   def ReadRootFile(self, filename):
     cur = self.checkout_root
     root = self.toplevel_root or self.checkout_root