chrome/renderer/resources/extensions/web_request_custom_bindings.js - Issue 11574006: Implement chrome.downloads.onDeterminingFilename()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/web_request_custom_bindings.js

Issue 11574006: Implement chrome.downloads.onDeterminingFilename() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: @r185012 Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/resources/extensions/downloads_custom_bindings.js ('K') | « chrome/renderer/resources/extensions/event.js ('k') | chrome/renderer/resources/renderer_resources.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/web_request_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/web_request_custom_bindings.js b/chrome/renderer/resources/extensions/web_request_custom_bindings.js

index 8699cbff664b6b488355836f0831625a713b01a1..9a458dedb8bc59a57456672e13ae50a5cd162b23 100644

--- a/chrome/renderer/resources/extensions/web_request_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/web_request_custom_bindings.js

@@ -59,6 +59,9 @@ WebRequestEvent.prototype.addListener =

function(cb, opt_filter, opt_extraInfo) {

if (!this.eventOptions_.supportsListeners)

throw new Error('This event does not support listeners.');

+ // NOTE(benjhayden) New APIs should not use this subEventName trick! It does

+ // not play well with event pages. See downloads.onDeterminingFilename and

+ // ExtensionDownloadsEventRouter for an alternative approach.

var subEventName = GetUniqueSubEventName(this.eventName_);

// Note: this could fail to validate, in which case we would not add the

// subEvent listener.