Implement chrome.downloads.onDeterminingFilename()

chrome/browser/extensions/api/downloads_internal/downloads_internal_api.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/api/downloads_internal/downloads_internal_api.h"
+
+#include <algorithm>
+#include <cctype>
+#include <iterator>
+#include <set>
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/callback.h"
+#include "base/json/json_writer.h"
+#include "base/lazy_instance.h"
+#include "base/logging.h"
+#include "base/metrics/histogram.h"
+#include "base/stl_util.h"
+#include "base/string16.h"
+#include "base/string_split.h"
+#include "base/string_util.h"
+#include "base/stringprintf.h"
+#include "base/values.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/download/download_file_icon_extractor.h"
+#include "chrome/browser/download/download_query.h"
+#include "chrome/browser/download/download_service.h"
+#include "chrome/browser/download/download_service_factory.h"
+#include "chrome/browser/download/download_util.h"
+#include "chrome/browser/extensions/api/downloads/downloads_api.h"
+#include "chrome/browser/extensions/event_names.h"
+#include "chrome/browser/extensions/event_router.h"
+#include "chrome/browser/extensions/extension_function_dispatcher.h"
+#include "chrome/browser/extensions/extension_system.h"
+#include "chrome/browser/icon_loader.h"
+#include "chrome/browser/icon_manager.h"
+#include "chrome/browser/renderer_host/chrome_render_message_filter.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/webui/web_ui_util.h"
+#include "chrome/common/cancelable_task_tracker.h"
+#include "chrome/common/chrome_notification_types.h"
+#include "chrome/common/extensions/api/downloads_internal.h"
+#include "content/public/browser/download_interrupt_reasons.h"
+#include "content/public/browser/download_item.h"
+#include "content/public/browser/download_save_info.h"
+#include "content/public/browser/download_url_parameters.h"
+#include "content/public/browser/notification_service.h"
+#include "content/public/browser/render_process_host.h"
+#include "content/public/browser/render_view_host.h"
+#include "content/public/browser/resource_context.h"
+#include "content/public/browser/resource_dispatcher_host.h"
+#include "content/public/browser/web_contents.h"
+#include "net/base/load_flags.h"
+#include "net/http/http_util.h"
+
+using content::DownloadItem;
+using content::DownloadManager;
+
+DownloadsInternalAddFilenameDeterminerFunction::
+DownloadsInternalAddFilenameDeterminerFunction() {}
+DownloadsInternalAddFilenameDeterminerFunction::
+~DownloadsInternalAddFilenameDeterminerFunction() {}
+
+typedef extensions::api::downloads_internal::AddFilenameDeterminer::Params
+  AddFilenameDeterminerParams;
+
+bool DownloadsInternalAddFilenameDeterminerFunction::RunImpl() {
+  scoped_ptr<AddFilenameDeterminerParams> params(
+      AddFilenameDeterminerParams::Create(*args_));
+  EXTENSION_FUNCTION_VALIDATE(params.get());
+  return ExtensionDownloadsEventRouter::AddFilenameDeterminer(
+      profile(),
+      include_incognito(),
+      GetExtension()->id(),
+      params->determiner_id);
+}
+
+DownloadsInternalRemoveFilenameDeterminerFunction::
+DownloadsInternalRemoveFilenameDeterminerFunction() {}
+DownloadsInternalRemoveFilenameDeterminerFunction::
+~DownloadsInternalRemoveFilenameDeterminerFunction() {}
+
+typedef extensions::api::downloads_internal::RemoveFilenameDeterminer::Params
+  RemoveFilenameDeterminerParams;
+
+bool DownloadsInternalRemoveFilenameDeterminerFunction::RunImpl() {
+  scoped_ptr<RemoveFilenameDeterminerParams> params(
+      RemoveFilenameDeterminerParams::Create(*args_));
+  EXTENSION_FUNCTION_VALIDATE(params.get());
+  return ExtensionDownloadsEventRouter::RemoveFilenameDeterminer(
+      profile(),
+      include_incognito(),
+      GetExtension()->id(),
+      params->determiner_id);
+}
+
+DownloadsInternalDetermineFilenameFunction::
+DownloadsInternalDetermineFilenameFunction() {}
+DownloadsInternalDetermineFilenameFunction::

[vabr (Chromium), 2013/01/11 12:43:40]

nit: Insert a blank line before the c-tor and d-tor definition.

[benjhayden, 2013/01/11 21:21:27]

Done.

+~DownloadsInternalDetermineFilenameFunction() {}
+
+typedef extensions::api::downloads_internal::DetermineFilename::Params
+  DetermineFilenameParams;

[battre, 2013/01/11 14:29:37]

nit: whitespaces

[benjhayden, 2013/01/11 21:21:27]

Done.

+
+bool DownloadsInternalDetermineFilenameFunction::RunImpl() {
+  scoped_ptr<DetermineFilenameParams> params(
+      DetermineFilenameParams::Create(*args_));
+  EXTENSION_FUNCTION_VALIDATE(params.get());
+  FilePath::StringType filename;
+  if (params->filename.get()) {
+    EXTENSION_FUNCTION_VALIDATE(args_->GetString(2, &filename));
+  }
+  return ExtensionDownloadsEventRouter::DetermineFilename(

[battre, 2013/01/11 14:29:37]

Why is this called "DetermineFilename" instead of "DeterminedFilename"? The
extension has determined the filename, right?

[benjhayden, 2013/01/11 21:21:27]

Actually, there's still most of the filename determination process left to do,
including prepending the default downloads directory, making the filename safe
for windows (prepending "nul" with an underscore, changing "foo.lnk" to
"foo.download", etc.), dangerous filename detection, and deduplication
(inserting " (1)" before the extension), not to mention the fact that another
extension may override with a different name.
A more accurate name might be "ContinueFilenameDeterminationProcess", but that
seemed a bit too long.
Still open to alternative names.

+      profile(),
+      include_incognito(),
+      GetExtension()->id(),
+      params->determiner_id,
+      params->download_id,
+      FilePath(filename),
+      params->overwrite);
+}