Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 11574: Fix the getintidentifier-special-values.html plugin layout test, which broke... (Closed)

Created:
12 years, 1 month ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix the getintidentifier-special-values.html plugin layout test, which broke as a result of change r5829 to fix silverlight windowless plugin issues. One of the changes was to return int32 as the variant type wherever applicable. Firefox does the same and Silverlight does rely on this behavior. This is broken in webkit. I will be filing a bug against webkit. The fix is to support int32 as an incoming NPVariant type in the layout test plugin. TBR=jam Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5837

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M webkit/tools/npapi_layout_test_plugin/PluginObject.cpp View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
12 years, 1 month ago (2008-11-21 19:49:02 UTC) #1
jam
12 years, 1 month ago (2008-11-21 21:37:32 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698