Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issue 1157393002: Version 4.3.61.26 (cherry-pick) (Closed)

Created:
5 years, 6 months ago by Erik Corry Chromium.org
Modified:
5 years, 6 months ago
Reviewers:
Yang
CC:
v8-dev, Paweł Hajdan Jr., ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@4.3
Target Ref:
refs/pending/branch-heads/4.3
Project:
v8
Visibility:
Public.

Description

Version 4.3.61.26 (cherry-pick) Merged 5a93a3304 Reland: Fix JSON parser Handle leak (previous CL 1041483004) BUG=472504, v8:3976 LOG=N R=yangguo@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/17db4ce193547f334c6cc63e27e1f9a0b434fcb7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -90 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M src/json-parser.h View 5 chunks +130 lines, -83 lines 0 comments Download
M test/mjsunit/regress/regress-3976.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-472504.js View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Erik Corry Chromium.org
5 years, 6 months ago (2015-05-28 15:06:12 UTC) #1
Yang
On 2015/05/28 15:06:12, Erik Corry Chromium.org wrote: lgtm
5 years, 6 months ago (2015-05-28 15:07:46 UTC) #2
Erik Corry Chromium.org
5 years, 6 months ago (2015-05-28 15:16:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
17db4ce193547f334c6cc63e27e1f9a0b434fcb7.

Powered by Google App Engine
This is Rietveld 408576698