Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1157383004: Delete constant declarations from v8_initializer.h that have no definitions (Closed)

Created:
5 years, 6 months ago by agrieve
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@awassets
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete constant declarations from v8_initializer.h that have no definitions BUG= Committed: https://crrev.com/d31dd3fc2f0a947515bf0c82638631d179fa1e4b Cr-Commit-Position: refs/heads/master@{#331950}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M gin/v8_initializer.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
agrieve
5 years, 6 months ago (2015-05-28 16:50:00 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-05-29 11:13:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157383004/1
5 years, 6 months ago (2015-05-29 12:19:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-29 12:55:36 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 12:56:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d31dd3fc2f0a947515bf0c82638631d179fa1e4b
Cr-Commit-Position: refs/heads/master@{#331950}

Powered by Google App Engine
This is Rietveld 408576698