DescriptionRevert of Fix the commit type for out-of-process iframes. (patchset #11 id:200001 of https://codereview.chromium.org/1148953014/)
Reason for revert:
Broke SitesPerProcess Tests on Mac OS 10.9
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/2330
Stack trace:
SitePerProcessBrowserTest.RFPHDestruction (run #1):
[ RUN ] SitePerProcessBrowserTest.RFPHDestruction
[2448:1287:0527/200828:279060882432:WARNING:vt_video_decode_accelerator.cc(198)] Failed to create hardware VideoToolbox session. Hardware accelerated video decoding will be disabled.
BrowserTestBase signal handler received SIGTERM. Backtrace:
0 content_browsertests 0x000000010566a983 base::debug::StackTrace::StackTrace() + 19
1 content_browsertests 0x0000000105432fa1 content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 65
2 libsystem_platform.dylib 0x00007fff924fd5aa _sigtramp + 26
3 ??? 0x0000000000000010 0x0 + 16
4 CoreFoundation 0x00007fff94b28f15 __CFRunLoopServiceMachPort + 181
5 CoreFoundation 0x00007fff94b28539 __CFRunLoopRun + 1161
6 CoreFoundation 0x00007fff94b27e75 CFRunLoopRunSpecific + 309
7 HIToolbox 0x00007fff8dc8ca0d RunCurrentEventLoopInMode + 226
8 HIToolbox 0x00007fff8dc8c7b7 ReceiveNextEventCommon + 479
9 HIToolbox 0x00007fff8dc8c5bc _BlockUntilNextEventMatchingListInModeWithFilter + 65
10 AppKit 0x00007fff8b3ca24e _DPSNextEvent + 1434
11 AppKit 0x00007fff8b3c989b -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 122
12 AppKit 0x00007fff8b3bd99c -[NSApplication run] + 553
13 content_browsertests 0x0000000105662681 base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 321
14 content_browsertests 0x0000000105661e2c base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 92
15 content_browsertests 0x0000000105699eb3 base::RunLoop::Run() + 99
16 content_browsertests 0x00000001054416df content::RunThisRunLoop(base::RunLoop*) + 79
17 content_browsertests 0x0000000105442570 content::NavigateFrameToURL(content::FrameTreeNode*, GURL const&) + 112
18 content_browsertests 0x000000010508b455 content::SitePerProcessBrowserTest_RFPHDestruction_Test::RunTestOnMainThread() + 325
19 content_browsertests 0x00000001053b1d7d content::ContentBrowserTest::RunTestOnMainThreadLoop() + 205
20 content_browsertests 0x0000000105432d56 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 262
21 content_browsertests 0x00000001053d84a2 content::ShellBrowserMainParts::PreMainMessageLoopRun() + 210
22 content_browsertests 0x0000000107ae36ef content::BrowserMainLoop::PreMainMessageLoopRun() + 143
23 content_browsertests 0x0000000107d670e7 content::StartupTaskRunner::RunAllTasksNow() + 39
24 content_browsertests 0x0000000107ae1d9e content::BrowserMainLoop::CreateStartupTasks() + 718
25 content_browsertests 0x0000000107ae5b55 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 405
26 content_browsertests 0x00000001053d7ee9 ShellBrowserMain(content::MainFunctionParams const&, scoped_ptr\u003Ccontent::BrowserMainRunner, base::DefaultDeleter\u003Ccontent::BrowserMainRunner> > const&) + 25
27 content_browsertests 0x00000001053c14ce content::ShellMainDelegate::RunProcess(std::string const&, content::MainFunctionParams const&) + 110
28 content_browsertests 0x0000000107a70f35 content::RunNamedProcessTypeMain(std::string const&, content::MainFunctionParams const&, content::ContentMainDelegate*) + 293
29 content_browsertests 0x0000000107a715bc content::ContentMainRunnerImpl::Run() + 92
30 content_browsertests 0x0000000107a70c86 content::ContentMain(content::ContentMainParams const&) + 54
31 content_browsertests 0x00000001054329bd content::BrowserTestBase::SetUp() + 765
32 content_browsertests 0x00000001053b1c22 content::ContentBrowserTest::SetUp() + 322
33 content_browsertests 0x000000010556c66f testing::Test::Run() + 319
34 content_browsertests 0x000000010556d2a4 testing::TestInfo::Run() + 436
35 content_browsertests 0x000000010556d733 testing::TestCase::Run() + 467
36 content_browsertests 0x0000000105573c7b testing::internal::UnitTestImpl::RunAllTests() + 827
37 content_browsertests 0x0000000105573911 testing::UnitTest::Run() + 257
38 content_browsertests 0x0000000105453acb base::TestSuite::Run() + 171
39 content_browsertests 0x00000001053b28aa content::ContentTestLauncherDelegate::RunTestSuite(int, char**) + 42
40 content_browsertests 0x000000010543e0d1 content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) + 321
41 content_browsertests 0x00000001053b284a main + 74
42 content_browsertests 0x0000000104ed6234 start + 52
43 ??? 0x0000000000000009 0x0 +
Original issue's description:
> Fix the commit type for out-of-process iframes.
>
> Passes a has_committed_real_load param to the renderer to let the
> (possibly new) FrameLoader know if there have been commits in that
> frame in the past, perhaps in another process.
>
> Also fixes broken invariants in NavigationController and tests.
>
> Only affects --site-per-process mode.
>
> BUG=464014
> TEST=Navigation tests still pass.
>
> Committed: https://crrev.com/62109d9af7c8db2c1bcaef715f04ca92b4d59746
> Cr-Commit-Position: refs/heads/master@{#331712}
TBR=avi@chromium.org,japhet@chromium.org,nasko@chromium.org,creis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464014
Committed: https://crrev.com/420384c6ea5496f4d55b6d01e409b49b22ce9d10
Cr-Commit-Position: refs/heads/master@{#331776}
Patch Set 1 #
Created: 5 years, 6 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|