Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(187)

Issue 1157363007: Refactoring: Use enum class for SerializationType (Closed)

Created:
4 years, 11 months ago by hajimehoshi
Modified:
4 years, 11 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Refactoring: Use enum class for SerializationType BUG=n/a TEST=n/a; no behavior change Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196302

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/core/editing/MarkupAccumulator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/MarkupAccumulator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XMLSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
hajimehoshi
PTAL
4 years, 11 months ago (2015-06-02 03:55:50 UTC) #2
tkent
lgtm
4 years, 11 months ago (2015-06-02 04:46:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157363007/1
4 years, 11 months ago (2015-06-02 04:47:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/64725)
4 years, 11 months ago (2015-06-02 06:47:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157363007/1
4 years, 11 months ago (2015-06-02 08:11:32 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-06-02 09:43:22 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196302

Powered by Google App Engine
This is Rietveld 408576698