Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: tools/promote.py

Issue 1157363002: Don't promote the eclipse plugins, we don't ship these from our main repo (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/promote.py
diff --git a/tools/promote.py b/tools/promote.py
index 5d3a3c4d87611874441f3f49d451ea77ed1068d9..ea420b416b65008eaff29aeb424c9299db65e17b 100644
--- a/tools/promote.py
+++ b/tools/promote.py
@@ -103,7 +103,7 @@ def _PromoteDartArchiveBuild(channel, revision):
def promote(to_revision):
def safety_check_on_gs_path(gs_path, revision, channel):
- if not ((revision == 'latest' or int(revision) > 0)
+ if not (revision != None
and len(channel) > 0
and ('%s' % revision) in gs_path
and channel in gs_path):
@@ -137,12 +137,6 @@ def _PromoteDartArchiveBuild(channel, revision):
remove_gs_directory(to_loc)
Gsutil(['-m', 'cp', '-a', 'public-read', '-R', from_loc, to_loc])
- # Copy eclipse update directory.
- from_loc = raw_namer.editor_eclipse_update_directory(revision)
- to_loc = release_namer.editor_eclipse_update_directory(to_revision)
- remove_gs_directory(to_loc)
- Gsutil(['-m', 'cp', '-a', 'public-read', '-R', from_loc, to_loc])
-
# Copy api-docs zipfile.
from_loc = raw_namer.apidocs_zipfilepath(revision)
to_loc = release_namer.apidocs_zipfilepath(to_revision)
@@ -166,7 +160,6 @@ def _PromoteDartArchiveBuild(channel, revision):
to_loc = release_namer.version_filepath(to_revision)
Gsutil(['cp', '-a', 'public-read', from_loc, to_loc])
-
promote(revision)
promote('latest')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698