Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: net/base/auth.h

Issue 1157333005: [net/http auth] Use strings to identify authentication schemes. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/media/android/media_resource_getter_impl.cc ('k') | net/http/http_auth.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/auth.h
diff --git a/net/base/auth.h b/net/base/auth.h
index 62a59c8f9fdad03a834a37ef4027313b43492f90..8dee1dbdece57ad12beabeb335d8ffe74d6edb0b 100644
--- a/net/base/auth.h
+++ b/net/base/auth.h
@@ -30,8 +30,7 @@ class NET_EXPORT AuthChallengeInfo :
// The service issuing the challenge.
HostPortPair challenger;
- // The authentication scheme used, such as "basic" or "digest". If the
- // |source| is FTP_SERVER, this is an empty string. The encoding is ASCII.
+ // The authentication scheme used, such as "basic" or "digest".
std::string scheme;
// The realm of the challenge. May be empty. The encoding is UTF-8.
@@ -89,6 +88,8 @@ enum AuthState {
AUTH_STATE_CANCELED
};
+// TODO(asanka): This is only used by URLRequestFtpJob. Get rid of this and move
+// the functionality to that class. http://crbug.com/529319
class AuthData : public base::RefCountedThreadSafe<AuthData> {
public:
AuthState state; // whether we need, have, or gave up on authentication.
« no previous file with comments | « content/browser/media/android/media_resource_getter_impl.cc ('k') | net/http/http_auth.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698