[net/http auth] Use strings to identify authentication schemes.

net/http/http_auth_handler_digest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_auth_handler_digest.h"
 
 #include <string>
 
 #include "base/logging.h"
 #include "base/md5.h"
 #include "base/rand_util.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "net/base/net_errors.h"
 #include "net/base/net_string_util.h"
 #include "net/base/net_util.h"
 #include "net/http/http_auth.h"
 #include "net/http/http_auth_challenge_tokenizer.h"
 #include "net/http/http_request_info.h"
 #include "net/http/http_util.h"
 #include "url/gurl.h"
 
 namespace net {
 
+static const char* const kDigestSchemeName = "digest";
+
 // Digest authentication is specified in RFC 2617.
 // The expanded derivations are listed in the tables below.
 
 //==========+==========+==========================================+
 //    qop   |algorithm |               response                   |
 //==========+==========+==========================================+
 //    ?     |  ?, md5, | MD5(MD5(A1):nonce:MD5(A2))               |
 //          | md5-sess |                                          |
 //--------- +----------+------------------------------------------+
 //   auth,  |  ?, md5, | MD5(MD5(A1):nonce:nc:cnonce:qop:MD5(A2)) |
@@ skipping 70 matching lines @@
   handler->swap(tmp_handler);
   return OK;
 }
 
 HttpAuth::AuthorizationResult HttpAuthHandlerDigest::HandleAnotherChallenge(
     HttpAuthChallengeTokenizer* challenge) {
   // Even though Digest is not connection based, a "second round" is parsed
   // to differentiate between stale and rejected responses.
   // Note that the state of the current handler is not mutated - this way if
   // there is a rejection the realm hasn't changed.
-  if (!base::LowerCaseEqualsASCII(challenge->scheme(), "digest"))
+  if (!challenge->SchemeIs(kDigestSchemeName))
     return HttpAuth::AUTHORIZATION_RESULT_INVALID;
 
   HttpUtil::NameValuePairsIterator parameters = challenge->param_pairs();
 
   // Try to find the "stale" value, and also keep track of the realm
   // for the new challenge.
   std::string original_realm;
   while (parameters.GetNext()) {
     if (base::LowerCaseEqualsASCII(parameters.name(), "stale")) {
       if (base::LowerCaseEqualsASCII(parameters.value(), "true"))
@@ skipping 54 matching lines @@
 //
 // Note that according to RFC 2617 (section 1.2) the realm is required.
 // However we allow it to be omitted, in which case it will default to the
 // empty string.
 //
 // This allowance is for better compatibility with webservers that fail to
 // send the realm (See http://crbug.com/20984 for an instance where a
 // webserver was not sending the realm with a BASIC challenge).
 bool HttpAuthHandlerDigest::ParseChallenge(
     HttpAuthChallengeTokenizer* challenge) {
-  auth_scheme_ = HttpAuth::AUTH_SCHEME_DIGEST;
-  score_ = 2;
-  properties_ = ENCRYPTS_IDENTITY;
+  auth_scheme_ = kDigestSchemeName;
 
   // Initialize to defaults.
   stale_ = false;
   algorithm_ = ALGORITHM_UNSPECIFIED;
   qop_ = QOP_UNSPECIFIED;
   realm_ = original_realm_ = nonce_ = domain_ = opaque_ = std::string();
 
   // FAIL -- Couldn't match auth-scheme.
-  if (!base::LowerCaseEqualsASCII(challenge->scheme(), "digest"))
+  if (!challenge->SchemeIs(kDigestSchemeName))
     return false;
 
   HttpUtil::NameValuePairsIterator parameters = challenge->param_pairs();
 
   // Loop through all the properties.
   while (parameters.GetNext()) {
     // FAIL -- couldn't parse a property.
     if (!ParseChallengeProperty(parameters.name(),
                                 parameters.value()))
       return false;
@@ skipping 161 matching lines @@
     // TODO(eroman): Supposedly IIS server requires quotes surrounding qop.
     authorization += ", qop=" + QopToString(qop_);
     authorization += ", nc=" + nc;
     authorization += ", cnonce=" + HttpUtil::Quote(cnonce);
   }
 
   return authorization;
 }
 
 }  // namespace net