Fix non-otr profile's file manager being launched in guest mode.

chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"
 
 #include <vector>
 
 #include "ash/ash_switches.h"
 #include "ash/desktop_background/desktop_background_controller.h"
@@ skipping 314 matching lines @@
                                                    ash::ShelfModel* model)
     : model_(model),
       item_delegate_manager_(NULL),
       profile_(profile),
       app_sync_ui_state_(NULL),
       ignore_persist_pinned_state_change_(false) {
   if (!profile_) {
     // If no profile was passed, we take the currently active profile and use it
     // as the owner of the current desktop.
     // Use the original profile as on chromeos we may get a temporary off the
-    // record profile.
-    profile_ = ProfileManager::GetActiveUserProfile()->GetOriginalProfile();
+    // record profile, unless in guest session (where off the record profile is
+    // the right one).
+    Profile* active_profile = ProfileManager::GetActiveUserProfile();
+    profile_ = active_profile->IsGuestSession() ? active_profile :
+        active_profile->GetOriginalProfile();

[Daniel Erat, 2013/12/19 20:25:54]

what does GetOriginalProfile() return if we're in guest mode? it seems broken if
we have both incognito and original profiles while we're in guest mode.

[tbarzic, 2013/12/19 20:50:30]

it returns the original profile; and it does seem a bit broken.
I don't know if we can create an incognito profile without an original, though.

[Daniel Erat, 2013/12/19 21:13:52]

until http://crbug.com/262299 is fixed, would it be better to make
GetOriginalProfile() automatically return the guest profile when
IsGuestSession() is true? would that prevent us from ever accidentally using the
"original" profile while in guest mode? (i have no idea if it'd be problematic
for other reasons.)

[rpetterson, 2013/12/19 21:28:15]

To my knowledge, you cannot create an incognito profile without an original
profile.

My primary concern would be security. That is if someone were able to access an
original profile they had no business using. I'm unsure how the guest profile is
different from the original profile and/or the incognito profile.

On 2013/12/19 21:13:52, Daniel Erat wrote:

 
     app_sync_ui_state_ = AppSyncUIState::Get(profile_);
     if (app_sync_ui_state_)
       app_sync_ui_state_->AddObserver(this);
   }
 
   // All profile relevant settings get bound to the current profile.
   AttachProfile(profile_);
   model_->AddObserver(this);
 
@@ skipping 1668 matching lines @@
 }
 
 void ChromeLauncherController::ReleaseProfile() {
   if (app_sync_ui_state_)
     app_sync_ui_state_->RemoveObserver(this);
 
   PrefServiceSyncable::FromProfile(profile_)->RemoveObserver(this);
 
   pref_change_registrar_.RemoveAll();
 }